ckaczor/FeedCenter
1
0
Fork 0
mirror of https://github.com/ckaczor/FeedCenter.git synced 2026-01-13 17:22:48 -05:00
Code Issues Packages Projects Releases Wiki Activity

Bunch of ReSharper suggestions

Browse Source
This commit is contained in:
Chris Kaczor
2015-11-02 20:29:00 -05:00
parent ff2ef0fd46
commit d8d7a9b5ba
15 changed files with 43 additions and 215 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Application/FeedParsers/AtomParser.cs
View File

@@ -1,5 +1,4 @@
using Common.Debug;
using Common.Xml;
using System.Xml;
namespace FeedCenter.FeedParsers
@@ -18,9 +17,6 @@ namespace FeedCenter.FeedParsers
// Load the XML document from the text
document.LoadXml(feedText);
// Create the namespace manager
var namespaceManager = document.GetAllNamespaces();
// Get the root node
XmlNode rootNode = document.DocumentElement;
@@ -62,7 +58,7 @@ namespace FeedCenter.FeedParsers
break;
case "entry":
HandleFeedItem(namespaceManager, node, ref sequence);
HandleFeedItem(node, ref sequence);
break;
}
}
@@ -77,7 +73,7 @@ namespace FeedCenter.FeedParsers
}
}
protected override FeedItem ParseFeedItem(XmlNamespaceManager namespaceManager, XmlNode node)
protected override FeedItem ParseFeedItem(XmlNode node)
{
// Create a new feed item
var feedItem = FeedItem.Create();

10
Application/FeedParsers/FeedParserBase.cs
View File

@@ -35,12 +35,12 @@ namespace FeedCenter.FeedParsers
public abstract FeedReadResult ParseFeed(string feedText);
protected abstract FeedItem ParseFeedItem(XmlNamespaceManager namespaceManager, XmlNode node);
protected abstract FeedItem ParseFeedItem(XmlNode node);
protected void HandleFeedItem(XmlNamespaceManager namespaceManager, XmlNode node, ref int sequence)
protected void HandleFeedItem(XmlNode node, ref int sequence)
{
// Build a feed item from the node
FeedItem newFeedItem = ParseFeedItem(namespaceManager, node);
FeedItem newFeedItem = ParseFeedItem(node);
if (newFeedItem == null)
return;
@@ -116,10 +116,10 @@ namespace FeedCenter.FeedParsers
return new AtomParser(feed);
}
throw new ArgumentException(string.Format("Feed type {0} is not supported", feedType));
throw new ArgumentException($"Feed type {feedType} is not supported");
}
public static FeedType DetectFeedType(string feedText)
private static FeedType DetectFeedType(string feedText)
{
try
{

4
Application/FeedParsers/RdfParser.cs
View File

@@ -64,7 +64,7 @@ namespace FeedCenter.FeedParsers
switch (node.Name)
{
case "item":
HandleFeedItem(namespaceManager, node, ref sequence);
HandleFeedItem(node, ref sequence);
break;
}
}
@@ -79,7 +79,7 @@ namespace FeedCenter.FeedParsers
}
}
protected override FeedItem ParseFeedItem(XmlNamespaceManager namespaceManager, XmlNode node)
protected override FeedItem ParseFeedItem(XmlNode node)
{
// Create a new feed item
FeedItem feedItem = FeedItem.Create();

4
Application/FeedParsers/RssParser.cs
View File

@@ -57,7 +57,7 @@ namespace FeedCenter.FeedParsers
break;
case "item":
HandleFeedItem(namespaceManager, node, ref sequence);
HandleFeedItem(node, ref sequence);
break;
}
}
@@ -72,7 +72,7 @@ namespace FeedCenter.FeedParsers
}
}
protected override FeedItem ParseFeedItem(XmlNamespaceManager namespaceManager, XmlNode node)
protected override FeedItem ParseFeedItem(XmlNode node)
{
// Create a new feed item
FeedItem feedItem = FeedItem.Create();