Update to .NET Core 3.1 and apply Roslyn suggestions

Weather/SerialReader/.vscode/launch.json

@@ -1,30 +1,30 @@
 {
-    // Use IntelliSense to find out which attributes exist for C# debugging
-    // Use hover for the description of the existing attributes
-    // For further information visit https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
     "version": "0.2.0",
     "configurations": [
         {
-            "name": ".NET Core Launch (remote console)",
+            "name": ".NET Core Launch (web)",
             "type": "coreclr",
             "request": "launch",
-            "preLaunchTask": "publish",
-            "program": "dotnet",
-            "args": [
-                "/home/ckaczor/Weather/SerialReader/SerialReader.dll"
-            ],
-            "cwd": "/home/ckaczor/Weather/SerialReader",
+            "preLaunchTask": "build",
+            "program": "${workspaceFolder}/bin/Debug/netcoreapp3.1/ChrisKaczor.HomeMonitor.Weather.SerialReader.dll",
+            "args": [],
+            "cwd": "${workspaceFolder}",
             "stopAtEntry": false,
-            "console": "internalConsole",
-            "pipeTransport": {
-                "pipeCwd": "${workspaceFolder}",
-                "pipeProgram": "C:\\Program Files (x86)\\PuTTY\\PLINK.EXE",
-                "pipeArgs": [
-                    "root@172.23.10.6"
-                ],
-                "debuggerPath": "/home/ckaczor/vsdbg/vsdbg"
+            "env": {
+                "ASPNETCORE_ENVIRONMENT": "Development"
             },
-            "internalConsoleOptions": "openOnSessionStart"
+            "sourceFileMap": {
+                "/Views": "${workspaceFolder}/Views"
+            }
+        },
+        {
+            "name": ".NET Core Attach",
+            "type": "coreclr",
+            "request": "attach",
+            "processId": "${command:pickProcess}"
         }
     ]
 }

Weather/SerialReader/.vscode/tasks.json

@@ -7,29 +7,54 @@
             "type": "process",
             "args": [
                 "build",
-                "${workspaceFolder}/SerialReader.csproj"
+                "${workspaceFolder}/SerialReader.csproj",
+                "/property:GenerateFullPaths=true",
+                "/consoleloggerparameters:NoSummary"
             ],
-            "problemMatcher": "$msCompile",
-            "group": {
-                "kind": "build",
-                "isDefault": true
-            }
+            "problemMatcher": "$msCompile"
         },
         {
             "label": "publish",
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "publish",
+                "${workspaceFolder}/SerialReader.csproj",
+                "/property:GenerateFullPaths=true",
+                "/consoleloggerparameters:NoSummary"
+            ],
+            "problemMatcher": "$msCompile"
+        },
+        {
+            "label": "watch",
+            "command": "dotnet",
+            "type": "process",
+            "args": [
+                "watch",
+                "run",
+                "${workspaceFolder}/SerialReader.csproj",
+                "/property:GenerateFullPaths=true",
+                "/consoleloggerparameters:NoSummary"
+            ],
+            "problemMatcher": "$msCompile"
+        },
+        {
+            "label": "build",
+            "command": "dotnet",
             "type": "shell",
+            "args": [
+                "build",
+                "/property:GenerateFullPaths=true",
+                "/consoleloggerparameters:NoSummary"
+            ],
+            "group": {
+                "kind": "build",
+                "isDefault": true
+            },
             "presentation": {
-                "reveal": "always",
-                "panel": "shared"
+                "reveal": "silent"
             },
-            "options": {
-                "cwd": "${workspaceFolder}"
-            },
-            "windows": {
-                "command": "${cwd}\\publish.bat"
-            },
-            "problemMatcher": [],
-            "group": "build"
+            "problemMatcher": "$msCompile"
         }
     ]
 }

Weather/SerialReader/Program.cs

@@ -139,7 +139,7 @@ namespace ChrisKaczor.HomeMonitor.Weather.SerialReader
 
                 var ports = SerialPort.GetPortNames();
 
-                var port = ports.FirstOrDefault(p => p.StartsWith(portPrefix));
+                var port = Array.Find(ports, p => p.StartsWith(portPrefix));
 
                 if (port != null)
                 {

Weather/SerialReader/SerialReader.csproj

@@ -2,7 +2,9 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>netcoreapp3.0</TargetFramework>
+    <TargetFramework>netcoreapp3.1</TargetFramework>
+    <CodeAnalysisRuleSet>../../ChrisKaczor.ruleset</CodeAnalysisRuleSet>
+    <GenerateTargetFrameworkAttribute>false</GenerateTargetFrameworkAttribute>
   </PropertyGroup>
 
   <PropertyGroup>