ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-06 01:25:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Replace deprecated assert functions in test files. (#16945)

Browse Source
This commit is contained in:
Cory Rivera
2021-08-31 09:04:17 -07:00
committed by GitHub
parent de3ff30398
commit 0082031f97
79 changed files with 1960 additions and 1965 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/platform/accounts/test/common/accountPickerViewModel.test.ts
View File

@@ -61,7 +61,7 @@ suite('Account picker view model tests', () => {
// Then:
// ... The event for the view models should be properly initialized
assert.notEqual(vm.updateAccountListEvent, undefined);
assert.notStrictEqual(vm.updateAccountListEvent, undefined);
// ... The event should properly fire
let argUpdateAccounts: UpdateAccountListEventParams = { providerId: providers[0].id, accountList: accounts };
@@ -89,8 +89,8 @@ suite('Account picker view model tests', () => {
// ... The results that were returned should be an array of account
assert.ok(Array.isArray(results));
assert.equal(results.length, 2);
assert.equal(results, accounts);
assert.strictEqual(results.length, 2);
assert.strictEqual(results, accounts);
});
});
@@ -112,7 +112,7 @@ suite('Account picker view model tests', () => {
// ... The results should be an empty array
assert.ok(Array.isArray(result));
assert.equal(result.length, 0);
assert.strictEqual(result.length, 0);
});
});
});

54
src/sql/platform/accounts/test/common/accountStore.test.ts
View File

@@ -27,7 +27,7 @@ suite('Account Store Tests', () => {
// ... The memento should have been initialized and account added
assert.ok(Array.isArray(memento[AccountStore.MEMENTO_KEY]));
assert.equal(memento[AccountStore.MEMENTO_KEY].length, 1);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY].length, 1);
assertAccountEqual(memento[AccountStore.MEMENTO_KEY][0], account1);
});
});
@@ -49,7 +49,7 @@ suite('Account Store Tests', () => {
// ... The memento should have the account added
assert.ok(Array.isArray(memento[AccountStore.MEMENTO_KEY]));
assert.equal(memento[AccountStore.MEMENTO_KEY].length, 1);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY].length, 1);
assertAccountEqual(memento[AccountStore.MEMENTO_KEY][0], account1);
});
});
@@ -75,7 +75,7 @@ suite('Account Store Tests', () => {
// ... The memento should have been initialized and account updated
assert.ok(Array.isArray(memento[AccountStore.MEMENTO_KEY]));
assert.equal(memento[AccountStore.MEMENTO_KEY].length, 2);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY].length, 2);
assertAccountEqual(memento[AccountStore.MEMENTO_KEY][0], account1);
assertAccountEqual(memento[AccountStore.MEMENTO_KEY][1], param);
});
@@ -92,10 +92,10 @@ suite('Account Store Tests', () => {
// Then:
// ... I should get back an empty array
assert.ok(Array.isArray(result));
assert.equal(result.length, 0);
assert.strictEqual(result.length, 0);
// ... Memento should not have been written
assert.equal(Object.keys(memento).length, 0);
assert.strictEqual(Object.keys(memento).length, 0);
});
});
@@ -110,7 +110,7 @@ suite('Account Store Tests', () => {
.then(result => {
// Then: I should get back an empty array
assert.ok(Array.isArray(result));
assert.equal(result.length, 0);
assert.strictEqual(result.length, 0);
});
});
@@ -124,7 +124,7 @@ suite('Account Store Tests', () => {
.then(result => {
// Then: I should get back an empty array
assert.ok(Array.isArray(result));
assert.equal(result.length, 0);
assert.strictEqual(result.length, 0);
});
});
@@ -138,7 +138,7 @@ suite('Account Store Tests', () => {
.then(result => {
// Then: I should get the accounts
assert.ok(Array.isArray(result));
assert.equal(result.length, 2);
assert.strictEqual(result.length, 2);
assertAccountEqual(result[0], memento[AccountStore.MEMENTO_KEY][0]);
assertAccountEqual(result[1], memento[AccountStore.MEMENTO_KEY][1]);
});
@@ -155,10 +155,10 @@ suite('Account Store Tests', () => {
// Then:
// ... I should get back an empty array
assert.ok(Array.isArray(result));
assert.equal(result.length, 0);
assert.strictEqual(result.length, 0);
// ... Memento should not have been written
assert.equal(Object.keys(memento).length, 0);
assert.strictEqual(Object.keys(memento).length, 0);
});
});
@@ -173,7 +173,7 @@ suite('Account Store Tests', () => {
.then(result => {
// Then: I should get back an empty array
assert.ok(Array.isArray(result));
assert.equal(result.length, 0);
assert.strictEqual(result.length, 0);
});
});
@@ -187,7 +187,7 @@ suite('Account Store Tests', () => {
.then(result => {
// Then: I should get the accounts
assert.ok(Array.isArray(result));
assert.equal(result.length, 2);
assert.strictEqual(result.length, 2);
assertAccountEqual(result[0], memento[AccountStore.MEMENTO_KEY][0]);
assertAccountEqual(result[1], memento[AccountStore.MEMENTO_KEY][1]);
});
@@ -207,7 +207,7 @@ suite('Account Store Tests', () => {
// ... The memento should have been initialized
assert.ok(Array.isArray(memento[AccountStore.MEMENTO_KEY]));
assert.equal(memento[AccountStore.MEMENTO_KEY].length, 0);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY].length, 0);
});
});
@@ -226,7 +226,7 @@ suite('Account Store Tests', () => {
// ... The memento should still be empty
assert.ok(Array.isArray(memento[AccountStore.MEMENTO_KEY]));
assert.equal(memento[AccountStore.MEMENTO_KEY].length, 0);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY].length, 0);
});
});
@@ -244,7 +244,7 @@ suite('Account Store Tests', () => {
// ... The memento should have removed the first account
assert.ok(Array.isArray(memento[AccountStore.MEMENTO_KEY]));
assert.equal(memento[AccountStore.MEMENTO_KEY].length, 1);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY].length, 1);
assertAccountEqual(memento[AccountStore.MEMENTO_KEY][0], account2);
});
});
@@ -267,7 +267,7 @@ suite('Account Store Tests', () => {
// ... The memento should have been initialized
assert.ok(Array.isArray(memento[AccountStore.MEMENTO_KEY]));
assert.equal(memento[AccountStore.MEMENTO_KEY].length, 0);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY].length, 0);
// ... The callback shouldn't have been called
updateCallback.assertNotFired();
@@ -292,7 +292,7 @@ suite('Account Store Tests', () => {
// ... The memento should still be empty
assert.ok(Array.isArray(memento[AccountStore.MEMENTO_KEY]));
assert.equal(memento[AccountStore.MEMENTO_KEY].length, 0);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY].length, 0);
// ... The callback shouldn't have been called
updateCallback.assertNotFired();
@@ -319,10 +319,10 @@ suite('Account Store Tests', () => {
// ... The memento still contains two accounts
assert.ok(Array.isArray(memento[AccountStore.MEMENTO_KEY]));
assert.equal(memento[AccountStore.MEMENTO_KEY].length, 2);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY].length, 2);
// ... Account 1 should have been updated
assert.equal(memento[AccountStore.MEMENTO_KEY][0].displayInfo.displayName, newDisplayName);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY][0].displayInfo.displayName, newDisplayName);
// ... Account 2 should have stayed the same
assertAccountEqual(memento[AccountStore.MEMENTO_KEY][1], account2);
@@ -334,11 +334,11 @@ suite('Account Store Tests', () => {
memento[AccountStore.MEMENTO_KEY].push(deprecatedAccount1, deprecatedAccount2);
let as = new AccountStore(memento, consoleLogService);
// We know that we have 4 accounts now
assert.equal(memento[AccountStore.MEMENTO_KEY].length, 4);
assert.strictEqual(memento[AccountStore.MEMENTO_KEY].length, 4);
return as.getAllAccounts().then(accounts => {
// After pruning we will have 2 accounts
assert.equal(accounts.length, 2);
assert.strictEqual(accounts.length, 2);
});
});
@@ -406,12 +406,12 @@ function getTestMemento() {
}
function assertAccountEqual(a: azdata.Account, b: azdata.Account) {
assert.equal(a.key.providerId, b.key.providerId);
assert.equal(a.key.accountId, b.key.accountId);
assert.strictEqual(a.key.providerId, b.key.providerId);
assert.strictEqual(a.key.accountId, b.key.accountId);
assert.equal(a.displayInfo.contextualDisplayName, b.displayInfo.contextualDisplayName);
assert.equal(a.displayInfo.accountType, b.displayInfo.accountType);
assert.equal(a.displayInfo.displayName, b.displayInfo.displayName);
assert.strictEqual(a.displayInfo.contextualDisplayName, b.displayInfo.contextualDisplayName);
assert.strictEqual(a.displayInfo.accountType, b.displayInfo.accountType);
assert.strictEqual(a.displayInfo.displayName, b.displayInfo.displayName);
assert.equal(a.isStale, b.isStale);
assert.strictEqual(a.isStale, b.isStale);
}

20
src/sql/platform/accounts/test/common/accountViewModel.test.ts
View File

@@ -68,9 +68,9 @@ suite('Account Management Dialog ViewModel Tests', () => {
// Then:
// ... All the events for the view models should be properly initialized
assert.notEqual(vm.addProviderEvent, undefined);
assert.notEqual(vm.removeProviderEvent, undefined);
assert.notEqual(vm.updateAccountListEvent, undefined);
assert.notStrictEqual(vm.addProviderEvent, undefined);
assert.notStrictEqual(vm.removeProviderEvent, undefined);
assert.notStrictEqual(vm.updateAccountListEvent, undefined);
// ... All the events should properly fire
let argAddProvider: AccountProviderAddedEventParams = { addedProvider: providers[0], initialAccounts: [] };
@@ -113,9 +113,9 @@ suite('Account Management Dialog ViewModel Tests', () => {
// ... The results that were returned should be an array of account provider added event params
assert.ok(Array.isArray(results));
assert.equal(results.length, 1);
assert.equal(results[0].addedProvider, providers[0]);
assert.equal(results[0].initialAccounts, accounts);
assert.strictEqual(results.length, 1);
assert.strictEqual(results[0].addedProvider, providers[0]);
assert.strictEqual(results[0].initialAccounts, accounts);
});
});
@@ -140,7 +140,7 @@ suite('Account Management Dialog ViewModel Tests', () => {
// ... The results that were returned should be an empty array
assert.ok(Array.isArray(results));
assert.equal(results.length, 0);
assert.strictEqual(results.length, 0);
});
});
@@ -165,9 +165,9 @@ suite('Account Management Dialog ViewModel Tests', () => {
// ... The results should include the provider
assert.ok(Array.isArray(result));
assert.equal(result.length, 1);
assert.equal(result[0].addedProvider, providers[0]);
assert.equal(result[0].initialAccounts, accounts);
assert.strictEqual(result.length, 1);
assert.strictEqual(result[0].addedProvider, providers[0]);
assert.strictEqual(result[0].initialAccounts, accounts);
});
});
});

20
src/sql/platform/accounts/test/common/firewallRuleViewModel.test.ts
View File

@@ -16,28 +16,28 @@ suite('Firewall rule view model tests', () => {
test('update default values to 250.222.155.198 should calculate the correct default subnet IP range', () => {
let IPAddress = '250.222.155.198';
viewModel.updateDefaultValues(IPAddress);
assert.equal(IPAddress, viewModel.defaultIPAddress);
assert.equal('250.222.155.0', viewModel.defaultFromSubnetIPRange);
assert.equal('250.222.155.255', viewModel.defaultToSubnetIPRange);
assert.strictEqual(IPAddress, viewModel.defaultIPAddress);
assert.strictEqual('250.222.155.0', viewModel.defaultFromSubnetIPRange);
assert.strictEqual('250.222.155.255', viewModel.defaultToSubnetIPRange);
});
test('update default values to 250.222.155.0 should calculate the correct default subnet IP range', () => {
let IPAddress = '250.222.155.2';
viewModel.updateDefaultValues(IPAddress);
assert.equal(IPAddress, viewModel.defaultIPAddress);
assert.equal('250.222.155.0', viewModel.defaultFromSubnetIPRange);
assert.equal('250.222.155.255', viewModel.defaultToSubnetIPRange);
assert.strictEqual(IPAddress, viewModel.defaultIPAddress);
assert.strictEqual('250.222.155.0', viewModel.defaultFromSubnetIPRange);
assert.strictEqual('250.222.155.255', viewModel.defaultToSubnetIPRange);
});
test('subnet IP range should return the correct values', () => {
let IPAddress = '250.222.155.198';
viewModel.updateDefaultValues(IPAddress);
assert.equal('250.222.155.0', viewModel.fromSubnetIPRange);
assert.equal('250.222.155.255', viewModel.toSubnetIPRange);
assert.strictEqual('250.222.155.0', viewModel.fromSubnetIPRange);
assert.strictEqual('250.222.155.255', viewModel.toSubnetIPRange);
viewModel.fromSubnetIPRange = '250.222.155.100';
viewModel.toSubnetIPRange = '250.222.155.220';
assert.equal('250.222.155.100', viewModel.fromSubnetIPRange);
assert.equal('250.222.155.220', viewModel.toSubnetIPRange);
assert.strictEqual('250.222.155.100', viewModel.fromSubnetIPRange);
assert.strictEqual('250.222.155.220', viewModel.toSubnetIPRange);
});
});