ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add additional notebook tests for handling relative links. (#17739)

Browse Source
This commit is contained in:
Cory Rivera
2021-11-29 10:09:25 -08:00
committed by GitHub
parent 0bac949d3b
commit 0149d9f051
2 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/sql/workbench/contrib/notebook/test/browser/notebookLinkHandler.test.ts
View File

@@ -61,6 +61,9 @@ suite('Noteboook Link Handler', function (): void {
result = new NotebookLinkHandler(notebookUri, Object.assign(document.createElement('a'), { href: '/tmp/inner/stuff.png' }), configurationService); result = new NotebookLinkHandler(notebookUri, Object.assign(document.createElement('a'), { href: '/tmp/inner/stuff.png' }), configurationService);
assert.strictEqual(result.getLinkUrl(), `.${path.sep}inner${path.sep}stuff.png`, 'Basic link test below folder failed'); assert.strictEqual(result.getLinkUrl(), `.${path.sep}inner${path.sep}stuff.png`, 'Basic link test below folder failed');
result = new NotebookLinkHandler(notebookUri, Object.assign(document.createElement('a'), { href: '/other/stuff.png' }), configurationService);
assert.strictEqual(result.getLinkUrl(), `..${path.sep}other${path.sep}stuff.png`, 'Basic link test in different above folder failed');
}); });
test('Should return anchor links', () => { test('Should return anchor links', () => {

24
src/sql/workbench/contrib/notebook/test/calloutDialog/linkCalloutDialog.test.ts
View File

@@ -124,7 +124,7 @@ suite('Link Callout Dialog', function (): void {
assert.strictEqual(unquoteText(undefined), undefined); assert.strictEqual(unquoteText(undefined), undefined);
}); });
test('Should return file link properly', async function (): Promise<void> { test('Should return absolute file link properly', async function (): Promise<void> {
const defaultLabel = 'defaultLabel'; const defaultLabel = 'defaultLabel';
const sampleUrl = 'C:/Test/Test.ipynb'; const sampleUrl = 'C:/Test/Test.ipynb';
let linkCalloutDialog = new LinkCalloutDialog('Title', 'below', defaultDialogProperties, defaultLabel, sampleUrl, let linkCalloutDialog = new LinkCalloutDialog('Title', 'below', defaultDialogProperties, defaultLabel, sampleUrl,
@@ -146,6 +146,28 @@ suite('Link Callout Dialog', function (): void {
assert.strictEqual(result.insertEscapedMarkdown, `[${defaultLabel}](${sampleUrl})`, 'Markdown not returned correctly'); assert.strictEqual(result.insertEscapedMarkdown, `[${defaultLabel}](${sampleUrl})`, 'Markdown not returned correctly');
}); });
test('Should return relative file link properly', async function (): Promise<void> {
const defaultLabel = 'defaultLabel';
const sampleUrl = '../../Test.ipynb';
let linkCalloutDialog = new LinkCalloutDialog('Title', 'below', defaultDialogProperties, defaultLabel, sampleUrl,
undefined, themeService, layoutService, telemetryService, contextKeyService, undefined, undefined, undefined);
linkCalloutDialog.render();
let deferred = new Deferred<ILinkCalloutDialogOptions>();
// When I first open the callout dialog
linkCalloutDialog.open().then(value => {
deferred.resolve(value);
});
linkCalloutDialog.url = sampleUrl;
// And insert the dialog
linkCalloutDialog.insert();
let result = await deferred.promise;
assert.strictEqual(result.insertUnescapedLinkLabel, defaultLabel, 'Label not returned correctly');
assert.strictEqual(result.insertUnescapedLinkUrl, sampleUrl, 'URL not returned correctly');
assert.strictEqual(result.insertEscapedMarkdown, `[${defaultLabel}](${sampleUrl})`, 'Markdown not returned correctly');
});
test('Should handle quoted URLs properly', async function (): Promise<void> { test('Should handle quoted URLs properly', async function (): Promise<void> {
const defaultLabel = 'defaultLabel'; const defaultLabel = 'defaultLabel';
const unquotedUrl = 'C:/Test/Test.ipynb'; const unquotedUrl = 'C:/Test/Test.ipynb';