ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix #4461 Dacpac: Extract lets me save to invalid file path like 'sd' and never adds .dacpac / .bacpac (#6424)

Browse Source 
* check for valid path

* add unit tests

* bump package version

* addressing comments
This commit is contained in:
Kim Santiago
2019-07-22 12:36:46 -07:00
committed by GitHub
parent 638456e5b0
commit 0246eec4ed
7 changed files with 160 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
extensions/dacpac/src/test/dacpac.test.ts
View File

@@ -7,8 +7,10 @@
import 'mocha';
import * as should from 'should';
import * as os from 'os';
import { isValidFilenameCharacter, sanitizeStringForFilename } from '../wizard/api/utils';
import * as path from 'path';
import { isValidFilenameCharacter, sanitizeStringForFilename, isValidBasename } from '../wizard/api/utils';
const isWindows = os.platform() === 'win32';
describe('Sanitize database name for filename tests', function (): void {
it('Should only validate if one character is passed', async () => {
@@ -25,8 +27,6 @@ describe('Sanitize database name for filename tests', function (): void {
});
it('Should determine invalid Windows file name characters', async () => {
let isWindows = os.platform() === 'win32';
// invalid only for Windows
should(isValidFilenameCharacter('?')).equal(isWindows ? false : true);
should(isValidFilenameCharacter(':')).equal(isWindows ? false : true);
@@ -45,3 +45,69 @@ describe('Sanitize database name for filename tests', function (): void {
should(sanitizeStringForFilename(invalidDbName)).equal(isWindows ? expectedWindows : expectedNonWindows);
});
});
describe('Check for invalid filename tests', function (): void {
it('Should determine invalid filenames', async () => {
// valid filename
should(isValidBasename(formatFileName('ValidName.dacpac'))).equal(true);
// invalid for both Windows and non-Windows
should(isValidBasename(formatFileName(' .dacpac'))).equal(false);
should(isValidBasename(formatFileName(' .dacpac'))).equal(false);
should(isValidBasename(formatFileName(' .dacpac'))).equal(false);
should(isValidBasename(formatFileName('..dacpac'))).equal(false);
should(isValidBasename(formatFileName('...dacpac'))).equal(false);
should(isValidBasename(null)).equal(false);
should(isValidBasename(undefined)).equal(false);
should(isValidBasename('\\')).equal(false);
should(isValidBasename('/')).equal(false);
// most file systems do not allow files > 255 length
should(isValidBasename(formatFileName('aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.dacpac'))).equal(false);
});
it('Should determine invalid Windows filenames', async () => {
// invalid characters only for Windows
should(isValidBasename(formatFileName('?.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName(':.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('*.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('<.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('>.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('|.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('".dacpac'))).equal(isWindows ? false : true);
// Windows filenames cannot end with a whitespace
should(isValidBasename(formatFileName('test .dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('test .dacpac'))).equal(isWindows ? false : true);
});
it('Should determine Windows forbidden filenames', async () => {
// invalid only for Windows
should(isValidBasename(formatFileName('CON.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('PRN.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('AUX.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('NUL.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('COM1.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('COM2.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('COM3.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('COM4.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('COM5.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('COM6.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('COM7.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('COM8.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('COM9.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('LPT1.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('LPT2.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('LPT3.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('LPT4.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('LPT5.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('LPT6.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('LPT7.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('LPT8.dacpac'))).equal(isWindows ? false : true);
should(isValidBasename(formatFileName('LPT9.dacpac'))).equal(isWindows ? false : true);
});
});
function formatFileName(filename: string): string {
return path.join(os.tmpdir(), filename);
}