ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-06 09:35:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix #4461 Dacpac: Extract lets me save to invalid file path like 'sd' and never adds .dacpac / .bacpac (#6424)

Browse Source 
* check for valid path

* add unit tests

* bump package version

* addressing comments
This commit is contained in:
Kim Santiago
2019-07-22 12:36:46 -07:00
committed by GitHub
parent 638456e5b0
commit 0246eec4ed
7 changed files with 160 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
extensions/dacpac/src/wizard/dataTierApplicationWizard.ts
View File

@@ -161,22 +161,17 @@ export class DataTierApplicationWizard {
});
this.wizard.onPageChanged(async (event) => {
let idx = event.newPage;
let page = this.getPage(idx);
if (page !== undefined) {
page.dacFxPage.setupNavigationValidator();
page.dacFxPage.onPageEnter();
let idxLast = event.lastPage;
let lastPage = this.getPage(idxLast);
if (lastPage) {
lastPage.dacFxPage.onPageLeave();
}
//do onPageLeave for summary page so that GenerateScript button only shows up if upgrading database
let idxLast = event.lastPage;
if (this.isSummaryPage(idxLast)) {
let lastPage = this.pages.get('summary');
if (lastPage) {
lastPage.dacFxPage.onPageLeave();
}
let idx = event.newPage;
let page = this.getPage(idx);
if (page) {
page.dacFxPage.setupNavigationValidator();
page.dacFxPage.onPageEnter();
}
});