ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix #4461 Dacpac: Extract lets me save to invalid file path like 'sd' and never adds .dacpac / .bacpac (#6424)

Browse Source 
* check for valid path

* add unit tests

* bump package version

* addressing comments
This commit is contained in:
Kim Santiago
2019-07-22 12:36:46 -07:00
committed by GitHub
parent 638456e5b0
commit 0246eec4ed
7 changed files with 160 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/dacpac/src/wizard/pages/exportConfigPage.ts
View File

@@ -52,6 +52,12 @@ export class ExportConfigPage extends DacFxConfigPage {
return r1 && r2;
}
async onPageLeave(): Promise<boolean> {
this.appendFileExtensionIfNeeded();
return true;
}
public setupNavigationValidator() {
this.instance.registerNavigationValidator(() => {
if (this.databaseLoader.loading) {

5
extensions/dacpac/src/wizard/pages/extractConfigPage.ts
View File

@@ -55,6 +55,11 @@ export class ExtractConfigPage extends DacFxConfigPage {
return r1 && r2;
}
async onPageLeave(): Promise<boolean> {
this.appendFileExtensionIfNeeded();
return true;
}
public setupNavigationValidator() {
this.instance.registerNavigationValidator(() => {
if (this.databaseLoader.loading) {