From 029c69ecd39bc4bcbab662bf5d9564c3503d5603 Mon Sep 17 00:00:00 2001 From: Gene Lee Date: Thu, 7 Mar 2019 13:35:10 -0800 Subject: [PATCH] =?UTF-8?q?Fixed=20issue:=20input=20change=20on=20dropdown?= =?UTF-8?q?box=20not=20reflected=20to=20'dropdownbox.=E2=80=A6=20(#4316)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/sql/base/browser/ui/editableDropdown/dropdown.ts | 5 +++++ src/sql/parts/modelComponents/dropdown.component.ts | 1 + 2 files changed, 6 insertions(+) diff --git a/src/sql/base/browser/ui/editableDropdown/dropdown.ts b/src/sql/base/browser/ui/editableDropdown/dropdown.ts index 209fa41d53..0658cf6866 100644 --- a/src/sql/base/browser/ui/editableDropdown/dropdown.ts +++ b/src/sql/base/browser/ui/editableDropdown/dropdown.ts @@ -96,6 +96,7 @@ export class Dropdown extends Disposable { private _filter = new DropdownFilter(); private _renderer = new DropdownRenderer(); private _controller = new DropdownController(); + public fireOnTextChange: boolean; private _onBlur = this._register(new Emitter()); public onBlur: Event = this._onBlur.event; @@ -211,6 +212,10 @@ export class Dropdown extends Disposable { this._filter.filterString = e; this._layoutTree(); } + if (this.fireOnTextChange) { + this.value = e; + this._onValueChange.fire(e); + } }); this._register(this._contextView); diff --git a/src/sql/parts/modelComponents/dropdown.component.ts b/src/sql/parts/modelComponents/dropdown.component.ts index 40f0cd36a0..e4b5c4a23f 100644 --- a/src/sql/parts/modelComponents/dropdown.component.ts +++ b/src/sql/parts/modelComponents/dropdown.component.ts @@ -112,6 +112,7 @@ export default class DropDownComponent extends ComponentBase implements ICompone this._editableDropdown.value = this.getSelectedValue(); } this._editableDropdown.enabled = this.enabled; + this._editableDropdown.fireOnTextChange = properties['fireOnTextChange']; } else { this._selectBox.setOptions(this.getValues()); this._selectBox.selectWithOptionName(this.getSelectedValue());