mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-01-17 17:22:42 -05:00
Adding Dacpac extension telemetry and core wizard/page telemetry updates(#13859)
* Dacpac telmetry code changes * Removed added spaces * Generate deployScript accessibility changed back to public * code review suggessions updates * dacpac extension tests fixes * Updated time and filesize methods allowing general return values * Telemetry code updates * Dacpac Telemetry potential data loss capture and PII error excluded * Dacpac telemetry code updates for comments * Wizard pages navigation telemetry event capture moved to the core * DacpacTelemetry code updates * Extension wizard cancel telemetry for data loss * Dacpac telemetry pagename and small code updates * final Dacpac telemetry code updates...
This commit is contained in:
committed by
GitHub
parent
07d798c949
commit
0316d9ac57
@@ -151,7 +151,7 @@ export class MainThreadModelViewDialog implements MainThreadModelViewDialogShape
|
||||
public $setWizardPageDetails(handle: number, details: IModelViewWizardPageDetails): Thenable<void> {
|
||||
let page = this._wizardPages.get(handle);
|
||||
if (!page) {
|
||||
page = new WizardPage(details.title, details.content);
|
||||
page = new WizardPage(details.title, details.content, details.pageName);
|
||||
page.onValidityChanged(valid => this._proxy.$onPanelValidityChanged(handle, valid));
|
||||
this._wizardPages.set(handle, page);
|
||||
this._wizardPageHandles.set(page, handle);
|
||||
@@ -161,6 +161,7 @@ export class MainThreadModelViewDialog implements MainThreadModelViewDialogShape
|
||||
page.content = details.content;
|
||||
page.enabled = details.enabled;
|
||||
page.description = details.description;
|
||||
page.pageName = details.pageName;
|
||||
if (details.customButtons !== undefined) {
|
||||
page.customButtons = details.customButtons.map(buttonHandle => this.getButton(buttonHandle));
|
||||
}
|
||||
|
||||
@@ -324,7 +324,8 @@ class WizardPageImpl extends ModelViewPanelImpl implements azdata.window.WizardP
|
||||
constructor(public title: string,
|
||||
extHostModelViewDialog: ExtHostModelViewDialog,
|
||||
extHostModelView: ExtHostModelViewShape,
|
||||
extension: IExtensionDescription) {
|
||||
extension: IExtensionDescription,
|
||||
public pageName?: string) {
|
||||
super('modelViewWizardPage', extHostModelViewDialog, extHostModelView, extension);
|
||||
}
|
||||
|
||||
@@ -758,8 +759,8 @@ export class ExtHostModelViewDialog implements ExtHostModelViewDialogShape {
|
||||
this._pageInfoChangedCallbacks.set(handle, callback);
|
||||
}
|
||||
|
||||
public createWizardPage(title: string, extension?: IExtensionDescription): azdata.window.WizardPage {
|
||||
let page = new WizardPageImpl(title, this, this._extHostModelView, extension);
|
||||
public createWizardPage(title: string, extension?: IExtensionDescription, pageName?: string): azdata.window.WizardPage {
|
||||
let page = new WizardPageImpl(title, this, this._extHostModelView, extension, pageName);
|
||||
page.handle = this.getHandle(page);
|
||||
return page;
|
||||
}
|
||||
@@ -781,7 +782,8 @@ export class ExtHostModelViewDialog implements ExtHostModelViewDialogShape {
|
||||
customButtons: page.customButtons ? page.customButtons.map(button => this.getHandle(button)) : undefined,
|
||||
enabled: page.enabled,
|
||||
title: page.title,
|
||||
description: page.description
|
||||
description: page.description,
|
||||
pageName: page.pageName
|
||||
});
|
||||
}
|
||||
|
||||
|
||||
@@ -435,8 +435,8 @@ export function createAdsApiFactory(accessor: ServicesAccessor): IAdsExtensionAp
|
||||
closeDialog(dialog: azdata.window.Dialog) {
|
||||
return extHostModelViewDialog.closeDialog(dialog);
|
||||
},
|
||||
createWizardPage(title: string): azdata.window.WizardPage {
|
||||
return extHostModelViewDialog.createWizardPage(title, extension);
|
||||
createWizardPage(title: string, pageName?: string): azdata.window.WizardPage {
|
||||
return extHostModelViewDialog.createWizardPage(title, extension, pageName);
|
||||
},
|
||||
createWizard(title: string, name?: string, width?: azdata.window.DialogWidth): azdata.window.Wizard {
|
||||
return extHostModelViewDialog.createWizard(title, name, width);
|
||||
|
||||
@@ -278,6 +278,7 @@ export interface IModelViewWizardPageDetails {
|
||||
enabled: boolean;
|
||||
customButtons: number[];
|
||||
description: string;
|
||||
pageName?: string;
|
||||
}
|
||||
|
||||
export interface IModelViewWizardDetails {
|
||||
|
||||
Reference in New Issue
Block a user