ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-11 02:32:35 -05:00
Code Issues Packages Projects Releases Wiki Activity

Warning for table max rows displayed (#4357)

Browse Source 
* Warning for top rows

* change single to double quotes when calling localize method
This commit is contained in:
Chris LaFreniere
2019-03-08 19:01:21 -08:00
committed by GitHub
parent 1e989060f9
commit 037c49e2c6
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sql/workbench/services/notebook/sql/sqlSessionManager.ts
View File

@@ -24,8 +24,8 @@ import { elapsedTimeLabel } from 'sql/parts/query/common/localizedConstants';
import * as notebookUtils from 'sql/parts/notebook/notebookUtils';
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
export const sqlKernel: string = localize('sqlKernel', 'SQL');
export const sqlKernelError: string = localize("sqlKernelError", "SQL kernel error");
export const sqlKernel: string = localize('sqlKernel', "SQL");
export const sqlKernelError: string = localize('sqlKernelError', "SQL kernel error");
export const MAX_ROWS = 5000;
export const NotebookConfigSectionName = 'notebook';
export const MaxTableRowsConfigName = 'maxTableRows';
@@ -249,7 +249,7 @@ class SqlKernel extends Disposable implements nb.IKernel {
this._future = new SQLFuture(this._queryRunner, count, this._configurationService);
if (!canRun) {
// Complete early
this._future.handleDone(new Error(localize('connectionRequired', 'A connection must be chosen to run notebook cells')));
this._future.handleDone(new Error(localize('connectionRequired', "A connection must be chosen to run notebook cells")));
}
// TODO should we cleanup old future? I don't think we need to
@@ -406,6 +406,9 @@ export class SQLFuture extends Disposable implements FutureInternal {
try {
for (let resultSet of batch.resultSetSummaries) {
let rowCount = resultSet.rowCount > this.configuredMaxRows ? this.configuredMaxRows : resultSet.rowCount;
if (rowCount === this.configuredMaxRows) {
this.handleMessage(localize('sqlMaxRowsDisplayed', "Displaying Top {0} rows.", rowCount));
}
await this.sendResultSetAsIOPub(rowCount, resultSet);
}
} catch (err) {