ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-14 18:46:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL-Migration] Login Migration Improvements (#21694)

Browse Source 
This PR adds various login migration improvements:

- Enabled windows login by prompting user for AAD domain name if a windows login is selected
image
- Adds new login details dialog which gives granular status on each step of the login migration for each login
image
- Checks if windows login migration is supported for selected target type, and only collections source windows logins accordingly
- Perf optimization by source and target login in background of step 1 in order to significantly speed up loading of page 2
This commit is contained in:
AkshayMata
2023-01-23 15:29:44 -08:00
committed by GitHub
parent 9d4d5374d7
commit 03f6a9b188
10 changed files with 820 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extensions/sql-migration/src/dashboard/dashboardTab.ts
View File

@@ -141,7 +141,7 @@ export class DashboardTab extends TabBase<DashboardTab> {
const toolbar = view.modelBuilder.toolbarContainer();
toolbar.addToolbarItems([
<azdata.ToolbarComponent>{ component: this.createNewMigrationButton() },
// <azdata.ToolbarComponent>{ component: this.createNewLoginMigrationButton() }, // TODO Enable when login migrations is ready for public consumption
<azdata.ToolbarComponent>{ component: this.createNewLoginMigrationButton() },
<azdata.ToolbarComponent>{ component: this.createNewSupportRequestButton() },
<azdata.ToolbarComponent>{ component: this.createFeedbackButton() },
]);

2
extensions/sql-migration/src/dashboard/migrationsListTab.ts
View File

@@ -143,8 +143,8 @@ export class MigrationsListTab extends TabBase<MigrationsListTab> {
}).component();
toolbar.addToolbarItems([
// <azdata.ToolbarComponent>{ component: this.createNewLoginMigrationButton(), toolbarSeparatorAfter: true },
<azdata.ToolbarComponent>{ component: this.createNewMigrationButton(), toolbarSeparatorAfter: true },
<azdata.ToolbarComponent>{ component: this.createNewLoginMigrationButton(), toolbarSeparatorAfter: true },
<azdata.ToolbarComponent>{ component: this.createNewSupportRequestButton() },
<azdata.ToolbarComponent>{ component: this.createFeedbackButton(), toolbarSeparatorAfter: true },
<azdata.ToolbarComponent>{ component: this._refreshLoader },