fix issue with setting false (#9611)

This commit is contained in:
Anthony Dresser
2020-03-16 11:12:57 -07:00
committed by GitHub
parent 11cf5654bf
commit 0405658be7
7 changed files with 71 additions and 8 deletions

View File

@@ -5,6 +5,7 @@
import { dispose, Disposable } from 'vs/base/common/lifecycle';
import { Event, Emitter } from 'vs/base/common/event';
import { isUndefined } from 'vs/base/common/types';
export class GridPanelState {
public tableStates: GridTableState[] = [];
@@ -30,7 +31,7 @@ export class GridTableState extends Disposable {
/* The top row of the current scroll */
public scrollPositionY = 0;
public scrollPositionX = 0;
public columnSizes?: number[] = undefined;
public columnSizes?: number[];
public selection?: Slick.Range[];
public activeCell?: Slick.Cell;
@@ -43,7 +44,7 @@ export class GridTableState extends Disposable {
}
public set canBeMaximized(val: boolean | undefined) {
if (!val || val === this._canBeMaximized) {
if (isUndefined(val) || val === this._canBeMaximized) {
return;
}
this._canBeMaximized = val;
@@ -55,7 +56,7 @@ export class GridTableState extends Disposable {
}
public set maximized(val: boolean | undefined) {
if (!val || val === this._maximized) {
if (isUndefined(val) || val === this._maximized) {
return;
}
this._maximized = val;

View File

@@ -10,7 +10,7 @@ import { TopOperationsState } from 'sql/workbench/common/editor/query/topOperati
import { ChartState } from 'sql/workbench/common/editor/query/chartState';
import { QueryPlanState } from 'sql/workbench/common/editor/query/queryPlanState';
import { MessagePanelState } from 'sql/workbench/common/editor/query/messagePanelState';
import { GridPanelState } from 'sql/workbench/common/editor/query/gridPanelState';
import { GridPanelState } from 'sql/workbench/common/editor/query/gridTableState';
import { QueryModelViewState } from 'sql/workbench/common/editor/query/modelViewState';
import { URI } from 'vs/base/common/uri';