ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add more error handling for python installation (#22650)

Browse Source
This commit is contained in:
Cory Rivera
2023-04-07 14:55:17 -07:00
committed by GitHub
parent 6a2ec12a35
commit 0412ba194b
1 changed files with 45 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
extensions/notebook/src/jupyter/jupyterServerInstallation.ts
View File

@@ -430,7 +430,7 @@ export class JupyterServerInstallation implements IJupyterServerInstallation {
this._installInProgress = true; this._installInProgress = true;
this._installCompletion = new Deferred<void>(); this._installCompletion = new Deferred<void>();
try {
this._pythonInstallationPath = installSettings.installPath; this._pythonInstallationPath = installSettings.installPath;
this._usingExistingPython = installSettings.existingPython; this._usingExistingPython = installSettings.existingPython;
await this.configurePackagePaths(); await this.configurePackagePaths();
@@ -470,11 +470,16 @@ export class JupyterServerInstallation implements IJupyterServerInstallation {
.catch(err => { .catch(err => {
let errorMsg = msgDependenciesInstallationFailed(utils.getErrorMessage(err)); let errorMsg = msgDependenciesInstallationFailed(utils.getErrorMessage(err));
op.updateStatus(azdata.TaskStatus.Failed, errorMsg); op.updateStatus(azdata.TaskStatus.Failed, errorMsg);
this._installCompletion.reject(errorMsg); this._installCompletion.reject(new Error(errorMsg));
this._installInProgress = false; this._installInProgress = false;
}); });
} }
}); });
} catch (err) {
let errorMsg = msgDependenciesInstallationFailed(utils.getErrorMessage(err));
this._installCompletion.reject(new Error(errorMsg));
this._installInProgress = false;
}
return this._installCompletion.promise; return this._installCompletion.promise;
} }