Vertical Toolbar Improvements and Fix for Untitled File Load Issue (#3189)

* Add horizontal toolbar

* Add vertical toolbar

* Fix for untitled scheme file load

* further fixes to vertical toolbar

* Addressing PR comments
This commit is contained in:
Chris LaFreniere
2018-11-13 11:05:54 -08:00
committed by GitHub
parent 0b571737b7
commit 06660160e7
8 changed files with 37 additions and 8 deletions

View File

@@ -21,6 +21,7 @@ import { SparkMagicContexts } from 'sql/parts/notebook/models/sparkMagicContexts
import { IConnectionProfile } from 'sql/parts/connection/common/interfaces';
import { NotebookConnection } from 'sql/parts/notebook/models/notebookConnection';
import { INotification, Severity } from 'vs/platform/notification/common/notification';
import { Schemas } from 'vs/base/common/network';
/*
* Used to control whether a message in a dialog/wizard is displayed as an error,
@@ -183,7 +184,10 @@ export class NotebookModel extends Disposable implements INotebookModel {
public async requestModelLoad(isTrusted: boolean = false): Promise<void> {
try {
this._trustedMode = isTrusted;
let contents = await this.notebookManager.contentManager.getNotebookContents(this.notebookOptions.notebookUri);
let contents = null;
if(this.notebookOptions.notebookUri.scheme !== Schemas.untitled) {
contents = await this.notebookManager.contentManager.getNotebookContents(this.notebookOptions.notebookUri);
}
let factory = this.notebookOptions.factory;
// if cells already exist, create them with language info (if it is saved)
this._cells = undefined;