ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-28 17:23:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix tabbing through Notebook cells (#9758)

Browse Source 
* Fix tabbing through Notebook cells

* Fix toggle tab command and re-order DOM
This commit is contained in:
Charles Gagnon
2020-03-27 13:23:25 -07:00
committed by GitHub
parent a9240f38f7
commit 068e1488cf
6 changed files with 30 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/sql/workbench/services/notebook/browser/models/cell.ts
View File

@@ -56,10 +56,6 @@ export class CellModel implements ICellModel {
private _isCollapsed: boolean;
private _onCollapseStateChanged = new Emitter<boolean>();
private _modelContentChangedEvent: IModelContentChangedEvent;
private readonly _ariaLabel: string;
private readonly codeCellLabel = localize('codeCellLabel', "Code Cell");
private readonly textCellLabel = localize('textCellLabel', "Text Cell");
constructor(cellData: nb.ICellContents,
private _options: ICellModelOptions,
@@ -74,12 +70,6 @@ export class CellModel implements ICellModel {
this._source = '';
}
if (this._cellType === CellTypes.Code) {
this._ariaLabel = this.codeCellLabel;
} else {
this._ariaLabel = this.textCellLabel;
}
this._isEditMode = this._cellType !== CellTypes.Markdown;
this._stdInVisible = false;
if (_options && _options.isTrusted) {
@@ -96,10 +86,6 @@ export class CellModel implements ICellModel {
return other !== undefined && other.id === this.id;
}
public get ariaLabel(): string {
return this._ariaLabel;
}
public get onCollapseStateChanged(): Event<boolean> {
return this._onCollapseStateChanged.event;
}

1
src/sql/workbench/services/notebook/browser/models/modelInterfaces.ts
View File

@@ -487,7 +487,6 @@ export interface ICellModel {
readonly onCellModeChanged: Event<boolean>;
modelContentChangedEvent: IModelContentChangedEvent;
isEditMode: boolean;
readonly ariaLabel: string;
}
export interface IModelFactory {