ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Agent: Accessibility bugs 2 (#5994)

Browse Source 
* made all jobs get focus and keyboard friendly

* added tooltip for steps image

* made operator dialog accessible

* localized tooltip
This commit is contained in:
Aditya Bist
2019-06-12 14:40:57 -07:00
committed by GitHub
parent 6c69eaef4c
commit 073a372d4d
4 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
extensions/agent/src/dialogs/operatorDialog.ts
View File

@@ -96,12 +96,21 @@ export class OperatorDialog extends AgentDialog<OperatorData> {
private initializeGeneralTab() { private initializeGeneralTab() {
this.generalTab.registerContent(async view => { this.generalTab.registerContent(async view => {
this.nameTextBox = view.modelBuilder.inputBox().component(); this.nameTextBox = view.modelBuilder.inputBox().withProperties({
ariaLabel: OperatorDialog.NameLabel,
placeHolder: OperatorDialog.NameLabel
}).component();
this.nameTextBox.value = this.model.name; this.nameTextBox.value = this.model.name;
this.emailNameTextBox = view.modelBuilder.inputBox().component(); this.emailNameTextBox = view.modelBuilder.inputBox().withProperties({
ariaLabel: OperatorDialog.EmailNameTextLabel,
placeHolder: OperatorDialog.EmailNameTextLabel
}).component();
this.emailNameTextBox.value = this.model.emailAddress; this.emailNameTextBox.value = this.model.emailAddress;
this.pagerEmailNameTextBox = view.modelBuilder.inputBox().component(); this.pagerEmailNameTextBox = view.modelBuilder.inputBox().withProperties({
ariaLabel: OperatorDialog.PagerEmailNameTextLabel,
placeHolder: OperatorDialog.PagerEmailNameTextLabel
}).component();
this.pagerEmailNameTextBox.value = this.model.pagerAddress; this.pagerEmailNameTextBox.value = this.model.pagerAddress;
this.enabledCheckBox = view.modelBuilder.checkBox() this.enabledCheckBox = view.modelBuilder.checkBox()

4
src/sql/workbench/parts/jobManagement/electron-browser/jobHistory.component.html
View File

@@ -10,8 +10,8 @@
</div> </div>
<!-- Back --> <!-- Back -->
<div class="all-jobs"> <div class="all-jobs" tabindex="0" (click)="goToJobs()" (keyup.enter)="goToJobs()">
<div class="back-button-icon" (click)="goToJobs()"></div>All Jobs <div class="back-button-icon" (click)="goToJobs()" (keyup.enter)="goToJobs()"></div>All Jobs
</div> </div>
<!-- Actions --> <!-- Actions -->

4
src/sql/workbench/parts/jobManagement/electron-browser/jobStepsView.component.ts
View File

@@ -4,7 +4,7 @@
*--------------------------------------------------------------------------------------------*/ *--------------------------------------------------------------------------------------------*/
import 'vs/css!./media/jobStepsView'; import 'vs/css!./media/jobStepsView';
import * as nls from 'vs/nls';
import * as dom from 'vs/base/browser/dom'; import * as dom from 'vs/base/browser/dom';
import { OnInit, Component, Inject, forwardRef, ElementRef, ChangeDetectorRef, ViewChild, AfterContentChecked } from '@angular/core'; import { OnInit, Component, Inject, forwardRef, ElementRef, ChangeDetectorRef, ViewChild, AfterContentChecked } from '@angular/core';
import { attachListStyler } from 'vs/platform/theme/common/styler'; import { attachListStyler } from 'vs/platform/theme/common/styler';
@@ -105,6 +105,8 @@ export class JobStepsViewComponent extends JobManagementView implements OnInit,
renderer: this._treeRenderer renderer: this._treeRenderer
}, { verticalScrollMode: ScrollbarVisibility.Visible, horizontalScrollMode: ScrollbarVisibility.Visible }); }, { verticalScrollMode: ScrollbarVisibility.Visible, horizontalScrollMode: ScrollbarVisibility.Visible });
this._register(attachListStyler(this._tree, this.themeService)); this._register(attachListStyler(this._tree, this.themeService));
const stepsTooltip = nls.localize('agent.steps', 'Steps');
jQuery('.steps-header > .steps-icon').attr('title', stepsTooltip);
this._telemetryService.publicLog(TelemetryKeys.JobStepsView); this._telemetryService.publicLog(TelemetryKeys.JobStepsView);
} }

2
src/sql/workbench/parts/jobManagement/electron-browser/media/jobHistory.css
View File

@@ -6,7 +6,9 @@
jobhistory-component .all-jobs { jobhistory-component .all-jobs {
display: inline-block; display: inline-block;
cursor: pointer;
font-size: 15px; font-size: 15px;
width: 10%;
} }
.overview-container .overview-tab .resultsViewCollapsible { .overview-container .overview-tab .resultsViewCollapsible {