Merge from vscode 8a997f7321ae6612fc0e6eb3eac4f358a6233bfb

test/unit/README.md

@@ -2,29 +2,23 @@
 
 ## Run (inside Electron)
 
-The best way to run the unit tests is from the terminal. To make development changes to unit tests you need to be running `yarn watch`. See [Development Workflow](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#incremental-build) for more details. From the `vscode` folder run:
+	./scripts/test.[sh|bat]
 
-**OS X and Linux**
-
-	./scripts/test.sh
-
-**Windows**
-
-	scripts\test
+All unit tests are run inside a electron-browser environment which access to DOM and Nodejs api. This is the closest to the enviroment in which VS Code itself ships. Notes:
 
+- use the `--debug` to see an electron window with dev tools which allows for debugging
+- to run only a subset of tests use the `--run` or `--glob` options
 
 ## Run (inside browser)
 
-You can run tests inside a browser instance too:
+	yarn test-browser --browser webkit --browser chromium
 
-**OS X and Linux**
-
-	node test/unit/browser/index.js
-
-**Windows**
-
-	node test\unit\browser\index.js
+Unit tests from layers `common` and `browser` are run inside `chromium`, `webkit`, and (soon’ish) `firefox` (using playwright). This complements our electron-based unit test runner and adds more coverage of supported platforms. Notes:
 
+- these tests are part of the continuous build, that means you might have test failures that only happen with webkit on _windows_ or _chromium_ on linux
+- you can these tests locally via yarn `test-browser --browser chromium --browser webkit`
+- to debug, open  `<vscode>/test/unit/browser/renderer.html` inside a browser and use the `?m=<amd_module>`-query to specify what AMD module to load, e.g `file:///Users/jrieken/Code/vscode/test/unit/browser/renderer.html?m=vs/base/test/common/strings.test` runs all tests from `strings.test.ts`
+- to run only a subset of tests use the `--run` or `--glob` options
 
 ## Run (with node)