From 0926057bfebfb774c56d0cc041ae425443c88c95 Mon Sep 17 00:00:00 2001 From: Yurong He <43652751+YurongHe@users.noreply.github.com> Date: Thu, 29 Nov 2018 19:28:08 -0800 Subject: [PATCH] Fixed #3294 removed dead code for "attach to" and remove disable to make it respond theme change (#3349) * Fixed #3294 * Fixed #3294 --- src/sql/parts/notebook/notebook.component.ts | 3 --- src/sql/parts/notebook/notebookActions.ts | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/src/sql/parts/notebook/notebook.component.ts b/src/sql/parts/notebook/notebook.component.ts index 33efd46f37..b2142d4243 100644 --- a/src/sql/parts/notebook/notebook.component.ts +++ b/src/sql/parts/notebook/notebook.component.ts @@ -239,9 +239,6 @@ export class NotebookComponent extends AngularDisposable implements OnInit { attachTodropdwon.render(attachToContainer); attachSelectBoxStyler(attachTodropdwon, this.themeService); - let attachToInfoText = document.createElement('div'); - attachToInfoText.className = 'notebook-info-label'; - attachToInfoText.innerText = 'Attach To: '; let addCodeCellButton = new AddCellAction('notebook.AddCodeCell', localize('code', 'Code'), 'notebook-button icon-add'); addCodeCellButton.cellType = CellTypes.Code; diff --git a/src/sql/parts/notebook/notebookActions.ts b/src/sql/parts/notebook/notebookActions.ts index c0777acf85..4639947d25 100644 --- a/src/sql/parts/notebook/notebookActions.ts +++ b/src/sql/parts/notebook/notebookActions.ts @@ -26,6 +26,7 @@ const msgLoadingContexts = localize('loadingContexts', 'Loading contexts...'); const msgAddNewConnection = localize('addNewConnection', 'Add new connection'); const msgSelectConnection = localize('selectConnection', 'Select connection'); const msgConnectionNotApplicable = localize('connectionNotSupported', 'n/a'); +const msgLocalHost = localize('localhost', 'Localhost'); // Action to add a cell to notebook based on cell type(code/markdown). export class AddCellAction extends Action { @@ -238,8 +239,7 @@ export class AttachToDropdown extends SelectBox { // Load "Attach To" dropdown with the values corresponding to Kernel dropdown public async loadAttachToDropdown(model: INotebookModel, currentKernel: string): Promise { if (currentKernel === notebookConstants.python3) { - this.setOptions([msgConnectionNotApplicable]); - this.disable(); + this.setOptions([msgLocalHost]); } else { let hadoopConnections = this.getHadoopConnections(model);