ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-05 09:35:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add separate dialog to notebook charts for specifying chart options. (#9454)

Browse Source
This commit is contained in:
Cory Rivera
2020-03-10 14:10:34 -07:00
committed by GitHub
parent 268463b5c7
commit 0a117fbd00
12 changed files with 150 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sql/workbench/contrib/notebook/browser/outputs/gridOutput.component.ts
View File

@@ -126,7 +126,7 @@ class DataResourceTable extends GridTableBase<any> {
) {
super(state, createResultSet(source), contextMenuService, instantiationService, editorService, untitledEditorService, configurationService);
this._gridDataProvider = this.instantiationService.createInstance(DataResourceDataProvider, source, this.resultSet, this.documentUri);
this._chart = this.instantiationService.createInstance(ChartView);
this._chart = this.instantiationService.createInstance(ChartView, false);
}
get gridDataProvider(): IGridDataProvider {
@@ -389,13 +389,13 @@ export class NotebookChartAction extends ToggleableAction {
public static SHOWCHART_LABEL = localize('notebook.showChart', "Show chart");
public static SHOWCHART_ICON = 'viewChart';
public static HIDECHART_LABEL = localize('notebook.hideChart', "Hide chart");
public static HIDECHART_ICON = 'close';
public static SHOWTABLE_LABEL = localize('notebook.showTable', "Show table");
public static SHOWTABLE_ICON = 'table';
constructor(private resourceTable: DataResourceTable) {
super(NotebookChartAction.ID, {
toggleOnLabel: NotebookChartAction.HIDECHART_LABEL,
toggleOnClass: NotebookChartAction.HIDECHART_ICON,
toggleOnLabel: NotebookChartAction.SHOWTABLE_LABEL,
toggleOnClass: NotebookChartAction.SHOWTABLE_ICON,
toggleOffLabel: NotebookChartAction.SHOWCHART_LABEL,
toggleOffClass: NotebookChartAction.SHOWCHART_ICON,
isOn: false