Fix backup (#4274)

* check to see whether options is available

* removing options state and using _modelOptions

* removed additional space

* making options getter private as not intended to expose
This commit is contained in:
Anup N. Kamath
2019-03-05 19:17:42 -08:00
committed by GitHub
parent e3709533b4
commit 0a268f35bc
2 changed files with 6 additions and 2 deletions

View File

@@ -74,6 +74,7 @@ const defaultOptions: IModalOptions = {
export abstract class Modal extends Disposable implements IThemable {
protected _useDefaultMessageBoxLocation: boolean = true;
protected _messageElement: HTMLElement;
protected _modalOptions: IModalOptions;
private _messageIcon: HTMLElement;
private _messageSeverity: Builder;
private _messageSummary: Builder;
@@ -114,7 +115,6 @@ export abstract class Modal extends Disposable implements IThemable {
private _keydownListener: IDisposable;
private _resizeListener: IDisposable;
private _modalOptions: IModalOptions;
private _backButton: Button;
private _modalShowingContext: IContextKey<Array<string>>;

View File

@@ -87,7 +87,7 @@ export class OptionsDialog extends Modal {
constructor(
title: string,
name: string,
private options: IOptionsDialogOptions,
options: IOptionsDialogOptions,
@IPartService partService: IPartService,
@IWorkbenchThemeService private _workbenchThemeService: IWorkbenchThemeService,
@IContextViewService private _contextViewService: IContextViewService,
@@ -178,6 +178,10 @@ export class OptionsDialog extends Modal {
}
}
private get options(): IOptionsDialogOptions {
return this._modalOptions as IOptionsDialogOptions;
}
public get optionValues(): { [name: string]: any } {
return this._optionValues;
}