ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-23 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix Edit Connection behavior that affects multiple areas working with edited connection (#20907)

Browse Source
This commit is contained in:
Cheena Malhotra
2022-10-21 11:03:10 -07:00
committed by GitHub
parent 5398339af9
commit 0abb8da026
5 changed files with 3 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/platform/connection/common/connectionConfig.ts
View File

@@ -93,8 +93,6 @@ export class ConnectionConfig {
});
if (sameProfileInList) {
let profileIndex = profiles.findIndex(value => value === sameProfileInList);
newProfile.id = sameProfileInList.id;
connectionProfile.id = sameProfileInList.id;
profiles[profileIndex] = newProfile;
} else {
profiles.push(newProfile);

3
src/sql/platform/connection/test/common/connectionConfig.test.ts
View File

@@ -325,9 +325,8 @@ suite('ConnectionConfig', () => {
connectionProfile.options['databaseDisplayName'] = existingConnection.options['databaseName'];
let config = new ConnectionConfig(configurationService, capabilitiesService.object);
let savedConnectionProfile = await config.addConnection(connectionProfile);
await config.addConnection(connectionProfile);
assert.strictEqual(savedConnectionProfile.id, existingConnection.id);
assert.strictEqual(configurationService.inspect<IConnectionProfileStore[]>('datasource.connections').userValue!.length, testConnections.length);
});