From 0bbc29079010f98a9089208a6c3864c78ceec140 Mon Sep 17 00:00:00 2001 From: Kim Santiago <31145923+kisantia@users.noreply.github.com> Date: Thu, 9 Mar 2023 14:21:43 -0800 Subject: [PATCH] fix accessibility issues in update project from db dialog (#22274) * fix accessibility issues in update project from db dialog * remove aria label on radio buttons --- .../src/dialogs/updateProjectFromDatabaseDialog.ts | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/extensions/sql-database-projects/src/dialogs/updateProjectFromDatabaseDialog.ts b/extensions/sql-database-projects/src/dialogs/updateProjectFromDatabaseDialog.ts index a8b55c0351..2b677137a1 100644 --- a/extensions/sql-database-projects/src/dialogs/updateProjectFromDatabaseDialog.ts +++ b/extensions/sql-database-projects/src/dialogs/updateProjectFromDatabaseDialog.ts @@ -179,7 +179,9 @@ export class UpdateProjectFromDatabaseDialog { this.serverDropdown = view.modelBuilder.dropDown().withProps({ editable: true, fireOnTextChange: true, - width: cssStyles.updateProjectFromDatabaseTextboxWidth + width: cssStyles.updateProjectFromDatabaseTextboxWidth, + ariaLabel: constants.server, + required: true }).component(); this.createConnectionButton(view); @@ -193,7 +195,9 @@ export class UpdateProjectFromDatabaseDialog { this.databaseDropdown = view.modelBuilder.dropDown().withProps({ editable: true, fireOnTextChange: true, - width: cssStyles.updateProjectFromDatabaseTextboxWidth + width: cssStyles.updateProjectFromDatabaseTextboxWidth, + ariaLabel: constants.databaseNameLabel, + required: true }).component(); this.databaseDropdown.onValueChanged(() => { @@ -382,7 +386,9 @@ export class UpdateProjectFromDatabaseDialog { fireOnTextChange: true, value: value, values: values, - width: cssStyles.updateProjectFromDatabaseTextboxWidth + width: cssStyles.updateProjectFromDatabaseTextboxWidth, + ariaLabel: constants.location, + required: true }).component(); this.projectFileDropdown.onValueChanged(async () => { @@ -491,7 +497,6 @@ export class UpdateProjectFromDatabaseDialog { const actionLabel = view.modelBuilder.text().withProps({ value: constants.actionLabel, - requiredIndicator: true, width: cssStyles.updateProjectFromDatabaseLabelWidth }).component();