mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-03-28 07:40:30 -04:00
Add token expiration handling for AzureMFA auth (#16936)
* refresh azure account token if it's expired before sending query/list requests * fix several connection checks && add more logging * fix async UI glitch during token refreshing * cleanup * minor fix * add test for refreshAzureAccountTokenIfNecessary * address comments * comments * comments * comments * error handling
This commit is contained in:
@@ -184,17 +184,20 @@ export abstract class AzureAuth implements vscode.Disposable {
|
||||
const currentTime = new Date().getTime() / 1000;
|
||||
|
||||
let accessToken = cachedTokens.accessToken;
|
||||
let expiresOn = Number(cachedTokens.expiresOn);
|
||||
const remainingTime = expiry - currentTime;
|
||||
const maxTolerance = 2 * 60; // two minutes
|
||||
|
||||
if (remainingTime < maxTolerance) {
|
||||
const result = await this.refreshToken(tenant, resource, cachedTokens.refreshToken);
|
||||
accessToken = result.accessToken;
|
||||
expiresOn = Number(result.expiresOn);
|
||||
}
|
||||
// Let's just return here.
|
||||
if (accessToken) {
|
||||
return {
|
||||
...accessToken,
|
||||
expiresOn: expiresOn,
|
||||
tokenType: 'Bearer'
|
||||
};
|
||||
}
|
||||
@@ -214,6 +217,7 @@ export abstract class AzureAuth implements vscode.Disposable {
|
||||
if (result.accessToken) {
|
||||
return {
|
||||
...result.accessToken,
|
||||
expiresOn: Number(result.expiresOn),
|
||||
tokenType: 'Bearer'
|
||||
};
|
||||
}
|
||||
@@ -674,6 +678,11 @@ export interface Token extends AccountKey {
|
||||
*/
|
||||
token: string;
|
||||
|
||||
/**
|
||||
* Access token expiry timestamp
|
||||
*/
|
||||
expiresOn?: number;
|
||||
|
||||
/**
|
||||
* TokenType
|
||||
*/
|
||||
|
||||
Reference in New Issue
Block a user