ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix notebook cancel query bug (#12300)

Browse Source 
* fix undefined query runner error

* store connection id

* revert sqlSessionManager change
This commit is contained in:
Lucy Zhang
2020-09-15 11:31:31 -07:00
committed by GitHub
parent 908a15d6a8
commit 0be5f67621
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/workbench/services/notebook/browser/models/clientSession.ts
View File

@@ -48,6 +48,7 @@ export class ClientSession implements IClientSession {
private isServerStarted: boolean; private isServerStarted: boolean;
private notebookManager: INotebookManager; private notebookManager: INotebookManager;
private _kernelConfigActions: ((kernelName: string) => Promise<any>)[] = []; private _kernelConfigActions: ((kernelName: string) => Promise<any>)[] = [];
private _connectionId: string = '';
constructor(private options: IClientSessionOptions) { constructor(private options: IClientSessionOptions) {
this._notebookUri = options.notebookUri; this._notebookUri = options.notebookUri;
@@ -288,8 +289,9 @@ export class ClientSession implements IClientSession {
// TODO is there any case where skipping causes errors? So far it seems like it gets called twice // TODO is there any case where skipping causes errors? So far it seems like it gets called twice
return; return;
} }
if (connection.id !== '-1') { if (connection.id !== '-1' && connection.id !== this._connectionId) {
await this._session.configureConnection(connection); await this._session.configureConnection(connection);
this._connectionId = connection.id;
} }
} }