Add support for 4 part version numbers (#8925)

* first crack at fix

* after test complete

* pr feedback + tests

* fix whitespace

* PR fedback
This commit is contained in:
Arvind Ranasaria
2020-02-13 16:59:22 -08:00
committed by GitHub
parent 321b41b7e1
commit 0c56d44e4f
4 changed files with 161 additions and 3 deletions

View File

@@ -11,6 +11,7 @@ import { AzdataInstallLocationKey, DeploymentConfigurationKey } from '../../cons
import { Command, OsDistribution, ToolType } from '../../interfaces';
import { IPlatformService } from '../platformService';
import { dependencyType, ToolBase } from './toolBase';
import { SemVerProxy } from './SemVerProxy';
const localize = nls.loadMessageBundle();
export const AzdataToolName = 'azdata';
@@ -58,7 +59,7 @@ export class AzdataTool extends ToolBase {
protected getVersionFromOutput(output: string): SemVer | undefined {
let version: SemVer | undefined = undefined;
if (output && output.split(EOL).length > 0) {
version = new SemVer(output.split(EOL)[0].replace(/ /g, ''));
version = new SemVerProxy(output.split(EOL)[0].replace(/ /g, ''));
}
return version;
}