ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

pass environment variables to Notebooks from ADS (#6389)

Browse Source 
* get the new environment variables for notebook

* comments

* Update serverInstance.ts

address comments

* be more specific when taking env variables
This commit is contained in:
Alan Ren
2019-07-18 10:40:07 -07:00
committed by GitHub
parent d74c2d6c8d
commit 0c5d5f1dd5
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/notebook/src/jupyter/serverInstance.ts
View File

@@ -377,8 +377,13 @@ export class PerNotebookServerInstance implements IServerInstance {
return childProcess; return childProcess;
} }
private getEnvWithConfigPaths(env: {}): any { private getEnvWithConfigPaths(env: { [key: string]: string }): any {
// Take the variables that starts with 'AZDATA_NB_VAR_' from process.env object so that we can pass information to notebooks
let newEnv: { [key: string]: string } = Object.assign({}, env); let newEnv: { [key: string]: string } = Object.assign({}, env);
Object.keys(process.env).filter(key => key.startsWith('AZDATA_NB_VAR_')).forEach(key => {
newEnv[key] = process.env[key];
});
newEnv['JUPYTER_CONFIG_DIR'] = this.instanceConfigRoot; newEnv['JUPYTER_CONFIG_DIR'] = this.instanceConfigRoot;
newEnv['JUPYTER_PATH'] = this.instanceDataRoot; newEnv['JUPYTER_PATH'] = this.instanceDataRoot;
return newEnv; return newEnv;