ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-01 09:35:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

[SQL Migration] Consume more detailed migration states (#20490)

Browse Source 
* WIP

* Add new states

* Missed a few spots

* Update logic

* Update DatabaseMigrationProperties

* Test: add mocks

* Update a few more references

* Fix warnings

* Remove mocks

* Update cutover logic

* Address PR feedback
This commit is contained in:
Raymond Truong
2022-10-28 17:14:12 -07:00
committed by GitHub
parent f4711d3c9c
commit 0dc8e18230
6 changed files with 81 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
extensions/sql-migration/src/constants/helper.ts
View File

@@ -158,41 +158,49 @@ export function hasMigrationOperationId(migration: DatabaseMigration | undefined
export function canCancelMigration(migration: DatabaseMigration | undefined): boolean {
const status = getMigrationStatus(migration);
return hasMigrationOperationId(migration)
&& (status === loc.MigrationStatus.InProgress ||
status === loc.MigrationStatus.Retriable ||
status === loc.MigrationStatus.Creating);
&& (status === loc.MigrationState.InProgress
|| status === loc.MigrationState.Retriable
|| status === loc.MigrationState.Creating
|| status === loc.MigrationState.ReadyForCutover
|| status === loc.MigrationState.UploadingFullBackup
|| status === loc.MigrationState.UploadingLogBackup
|| status === loc.MigrationState.Restoring);
}
export function canDeleteMigration(migration: DatabaseMigration | undefined): boolean {
const status = getMigrationStatus(migration);
return status === loc.MigrationStatus.Canceled
|| status === loc.MigrationStatus.Failed
|| status === loc.MigrationStatus.Retriable
|| status === loc.MigrationStatus.Succeeded;
return status === loc.MigrationState.Canceled
|| status === loc.MigrationState.Failed
|| status === loc.MigrationState.Retriable
|| status === loc.MigrationState.Succeeded;
}
export function canRetryMigration(migration: DatabaseMigration | undefined): boolean {
const status = getMigrationStatus(migration);
return status === loc.MigrationStatus.Canceled
|| status === loc.MigrationStatus.Retriable
|| status === loc.MigrationStatus.Failed
|| status === loc.MigrationStatus.Succeeded;
return status === loc.MigrationState.Canceled
|| status === loc.MigrationState.Retriable
|| status === loc.MigrationState.Failed
|| status === loc.MigrationState.Succeeded;
}
export function canCutoverMigration(migration: DatabaseMigration | undefined): boolean {
const status = getMigrationStatus(migration);
return hasMigrationOperationId(migration)
&& status === loc.MigrationStatus.InProgress
&& isOnlineMigration(migration)
&& (status === loc.MigrationState.ReadyForCutover || status === loc.MigrationState.InProgress) // TODO: InProgress condition can be eventually deprecated
&& isFullBackupRestored(migration);
}
export function isActiveMigration(migration: DatabaseMigration | undefined): boolean {
const status = getMigrationStatus(migration);
return status === loc.MigrationStatus.Completing
|| status === loc.MigrationStatus.Retriable
|| status === loc.MigrationStatus.Creating
|| status === loc.MigrationStatus.InProgress;
return status === loc.MigrationState.Completing
|| status === loc.MigrationState.Retriable
|| status === loc.MigrationState.Creating
|| status === loc.MigrationState.InProgress
|| status === loc.MigrationState.ReadyForCutover
|| status === loc.MigrationState.UploadingFullBackup
|| status === loc.MigrationState.UploadingLogBackup
|| status === loc.MigrationState.Restoring;
}
export function isFullBackupRestored(migration: DatabaseMigration | undefined): boolean {

45
extensions/sql-migration/src/constants/strings.ts
View File

@@ -10,15 +10,20 @@ import { MigrationSourceAuthenticationType } from '../models/stateMachine';
import { formatNumber, ParallelCopyTypeCodes, PipelineStatusCodes } from './helper';
const localize = nls.loadMessageBundle();
export enum MigrationStatus {
Failed = 'Failed',
Succeeded = 'Succeeded',
InProgress = 'InProgress',
// mirrors MigrationState as defined in RP
export enum MigrationState {
Canceled = 'Canceled',
Canceling = 'Canceling',
Completing = 'Completing',
Creating = 'Creating',
Canceling = 'Canceling',
Failed = 'Failed',
InProgress = 'InProgress',
ReadyForCutover = 'ReadyForCutover',
Restoring = 'Restoring',
Retriable = 'Retriable',
Succeeded = 'Succeeded',
UploadingFullBackup = 'UploadingFullBackup',
UploadingLogBackup = 'UploadingLogBackup',
}
export enum ProvisioningState {
@@ -824,14 +829,18 @@ export interface LookupTable<T> {
}
export const StatusLookup: LookupTable<string | undefined> = {
[MigrationStatus.InProgress]: localize('sql.migration.status.inprogress', 'In progress'),
[MigrationStatus.Succeeded]: localize('sql.migration.status.succeeded', 'Succeeded'),
[MigrationStatus.Creating]: localize('sql.migration.status.creating', 'Creating'),
[MigrationStatus.Completing]: localize('sql.migration.status.completing', 'Completing'),
[MigrationStatus.Retriable]: localize('sql.migration.status.retriable', 'Retriable'),
[MigrationStatus.Canceling]: localize('sql.migration.status.canceling', 'Canceling'),
[MigrationStatus.Canceled]: localize('sql.migration.status.canceled', 'Canceled'),
[MigrationStatus.Failed]: localize('sql.migration.status.failed', 'Failed'),
[MigrationState.Canceled]: localize('sql.migration.status.canceled', 'Canceled'),
[MigrationState.Canceling]: localize('sql.migration.status.canceling', 'Canceling'),
[MigrationState.Completing]: localize('sql.migration.status.completing', 'Completing'),
[MigrationState.Creating]: localize('sql.migration.status.creating', 'Creating'),
[MigrationState.Failed]: localize('sql.migration.status.failed', 'Failed'),
[MigrationState.InProgress]: localize('sql.migration.status.inprogress', 'In progress'),
[MigrationState.ReadyForCutover]: localize('sql.migration.status.readyforcutover', 'Ready for cutover'),
[MigrationState.Restoring]: localize('sql.migration.status.restoring', 'Restoring'),
[MigrationState.Retriable]: localize('sql.migration.status.retriable', 'Retriable'),
[MigrationState.Succeeded]: localize('sql.migration.status.succeeded', 'Succeeded'),
[MigrationState.UploadingFullBackup]: localize('sql.migration.status.uploadingfullbackup', 'Uploading full backup'),
[MigrationState.UploadingLogBackup]: localize('sql.migration.status.uploadinglogbackup', 'Uploading log backup(s)'),
default: undefined
};
@@ -858,9 +867,13 @@ export const ParallelCopyType: LookupTable<string | undefined> = {
};
export function STATUS_WARNING_COUNT(status: string, count: number): string | undefined {
if (status === MigrationStatus.InProgress ||
status === MigrationStatus.Creating ||
status === MigrationStatus.Completing) {
if (status === MigrationState.InProgress ||
status === MigrationState.ReadyForCutover ||
status === MigrationState.UploadingFullBackup ||
status === MigrationState.UploadingLogBackup ||
status === MigrationState.Restoring ||
status === MigrationState.Creating ||
status === MigrationState.Completing) {
switch (count) {
case 0:
return undefined;