ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Only filter preview extensions when preview feat disabled (#10212)

Browse Source 
* Filter database preview tabs

* Update comment

* Revert changes - just update comment
This commit is contained in:
Charles Gagnon
2020-04-30 10:46:16 -07:00
committed by GitHub
parent fdc21bfb9e
commit 0e6117f044
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/sql/workbench/contrib/dashboard/browser/core/dashboardPage.component.ts
View File

@@ -300,7 +300,8 @@ export abstract class DashboardPage extends AngularDisposable implements IConfig
this.loadNewTabs(allTabs.filter((tab) => tab.group === homeTabGroupId)); this.loadNewTabs(allTabs.filter((tab) => tab.group === homeTabGroupId));
// If preview features are disabled only show the home tab // If preview features are disabled only show the home tab since extension-contributed tabs
// are still under preview
const extensionTabsEnabled = this.configurationService.getValue('workbench')['enablePreviewFeatures']; const extensionTabsEnabled = this.configurationService.getValue('workbench')['enablePreviewFeatures'];
if (!extensionTabsEnabled) { if (!extensionTabsEnabled) {
allTabs = []; allTabs = [];

1
src/sql/workbench/contrib/dashboard/browser/core/dashboardTab.contribution.ts
View File

@@ -167,7 +167,6 @@ ExtensionsRegistry.registerExtensionPoint<IDashboardTabContrib | IDashboardTabCo
if (isValidIcon(icon, extension)) { if (isValidIcon(icon, extension)) {
iconClass = createCSSRuleForIcon(icon, extension); iconClass = createCSSRuleForIcon(icon, extension);
} }
if (result) { if (result) {
registerTab({ description, title, container, provider, when, id, alwaysShow, publisher, isHomeTab, group, iconClass }); registerTab({ description, title, container, provider, when, id, alwaysShow, publisher, isHomeTab, group, iconClass });
} }

3
src/vs/platform/extensions/common/extensions.ts
View File

@@ -246,8 +246,7 @@ export interface IExtensionDescription extends IExtensionManifest {
readonly isUnderDevelopment: boolean; readonly isUnderDevelopment: boolean;
readonly extensionLocation: URI; readonly extensionLocation: URI;
enableProposedApi?: boolean; enableProposedApi?: boolean;
// {{ SQL CARBON EDIT }} readonly forceReload?: boolean; // {{ SQL CARBON EDIT }}
readonly forceReload?: boolean;
} }
export function isLanguagePackExtension(manifest: IExtensionManifest): boolean { export function isLanguagePackExtension(manifest: IExtensionManifest): boolean {