ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-22 09:35:37 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix more floating promises (#8460)

Browse Source
This commit is contained in:
Charles Gagnon
2019-11-27 08:04:51 -08:00
committed by GitHub
parent 4145ecfb32
commit 0e9797c394
14 changed files with 84 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/sql/workbench/browser/actions.ts
View File

@@ -64,9 +64,8 @@ export class InsightAction extends Action {
super(id, label);
}
run(actionContext: InsightActionContext): Promise<boolean> {
this._insightsDialogService.show(actionContext.insight, actionContext.profile);
return Promise.resolve(true);
async run(actionContext: InsightActionContext): Promise<void> {
await this._insightsDialogService.show(actionContext.insight, actionContext.profile);
}
}

8
src/sql/workbench/browser/modelComponents/fileBrowserTree.component.ts
View File

@@ -72,12 +72,12 @@ export default class FileBrowserTreeComponent extends ComponentBase implements I
}
}
private handleOnAddFileTree(rootNode: FileNode, selectedNode: FileNode, expandedNodes: FileNode[]) {
this.updateFileTree(rootNode, selectedNode, expandedNodes);
private async handleOnAddFileTree(rootNode: FileNode, selectedNode: FileNode, expandedNodes: FileNode[]): Promise<void> {
await this.updateFileTree(rootNode, selectedNode, expandedNodes);
}
private updateFileTree(rootNode: FileNode, selectedNode: FileNode, expandedNodes: FileNode[]): void {
this._treeView.renderBody(this._treeContainer.nativeElement, rootNode, selectedNode, expandedNodes);
private async updateFileTree(rootNode: FileNode, selectedNode: FileNode, expandedNodes: FileNode[]): Promise<void> {
await this._treeView.renderBody(this._treeContainer.nativeElement, rootNode, selectedNode, expandedNodes);
this._treeView.setVisible(true);
this.layoutTree();
this._changeRef.detectChanges();

6
src/sql/workbench/browser/taskUtilities.ts
View File

@@ -10,13 +10,11 @@ import {
RunQueryOnConnectionMode, IConnectionResult
} from 'sql/platform/connection/common/connectionManagement';
import { EditDataInput } from 'sql/workbench/contrib/editData/browser/editDataInput';
import { IInsightsDialogService } from 'sql/workbench/services/insights/browser/insightsDialogService';
import { IObjectExplorerService } from 'sql/workbench/services/objectExplorer/browser/objectExplorerService';
import { DashboardInput } from 'sql/workbench/contrib/dashboard/browser/dashboardInput';
import { ProfilerInput } from 'sql/workbench/contrib/profiler/browser/profilerInput';
import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
import { IInsightsConfig } from 'sql/platform/dashboard/browser/insightRegistry';
import { QueryEditorInput } from 'sql/workbench/contrib/query/common/queryEditorInput';
export function replaceConnection(oldUri: string, newUri: string, connectionService: IConnectionManagementService): Promise<IConnectionResult> {
@@ -56,10 +54,6 @@ export function replaceConnection(oldUri: string, newUri: string, connectionServ
});
}
export function openInsight(query: IInsightsConfig, profile: IConnectionProfile, insightDialogService: IInsightsDialogService) {
insightDialogService.show(query, profile);
}
/**
* Get the current global connection, which is the connection from the active editor, unless OE
* is focused or there is no such editor, in which case it comes from the OE selection. Returns