More layering and strictness (#9004)

* move handling generated files to the serilization classes

* remove unneeded methods

* add more folders to strictire compile, add more strict compile options

* update ci

* wip

* add more layering and fix issues

* add more strictness

* remove unnecessary assertion

* add missing checks

* fix indentation

* wip

* remove jsdoc

* fix layering

* fix compile

* fix compile errors

* wip

* wip

* finish layering

* fix css

* more layering

* remove no longer good parts

* fix issues with startup

* another try

* fix startup
This commit is contained in:
Anthony Dresser
2020-02-11 00:47:17 -06:00
committed by GitHub
parent 3a8b74a311
commit 0f934081e1
97 changed files with 489 additions and 214 deletions

View File

@@ -45,7 +45,7 @@ import { ITextFileService } from 'vs/workbench/services/textfile/common/textfile
import { basenameOrAuthority } from 'vs/base/common/resources';
// {{SQL CARBON EDIT}} -- Display the editor's tab color
import * as QueryConstants from 'sql/workbench/contrib/query/common/constants';
import * as QueryConstants from 'sql/platform/query/common/constants';
import * as WorkbenchUtils from 'sql/workbench/common/sqlWorkbenchUtils';
// {{SQL CARBON EDIT}} -- End

View File

@@ -45,7 +45,7 @@ import { coalesce } from 'vs/base/common/arrays';
import { InstantiationService } from 'vs/platform/instantiation/common/instantiationService';
import { Layout } from 'vs/workbench/browser/layout';
import { IHostService } from 'vs/workbench/services/host/browser/host';
import { ILanguageAssociationRegistry, Extensions as LanguageExtensions } from 'sql/workbench/common/languageAssociation';
import { ILanguageAssociationRegistry, Extensions as LanguageExtensions } from 'sql/workbench/services/languageAssociation/common/languageAssociation';
import { Extensions as PanelExtensions, PanelRegistry } from 'vs/workbench/browser/panel';
export class Workbench extends Layout {

View File

@@ -10,9 +10,7 @@ import { IConfigurationService, IConfigurationChangeEvent } from 'vs/platform/co
import { dispose, Disposable, DisposableStore } from 'vs/base/common/lifecycle';
import { Registry } from 'vs/platform/registry/common/platform';
import { coalesce } from 'vs/base/common/arrays';
// {{SQL CARBON EDIT}}
import { doHandleUpgrade } from 'sql/workbench/common/languageAssociation';
import { doHandleUpgrade } from 'sql/workbench/services/languageAssociation/common/doHandleUpgrade';
const EditorOpenPositioning = {
LEFT: 'left',

View File

@@ -151,7 +151,7 @@ import { IResourceProviderService } from 'sql/workbench/services/resourceProvide
import { ResourceProviderService } from 'sql/workbench/services/resourceProvider/browser/resourceProviderService';
import { IAdsTelemetryService } from 'sql/platform/telemetry/common/telemetry';
import { AdsTelemetryService } from 'sql/platform/telemetry/common/adsTelemetryService';
import { OEShimService, IOEShimService } from 'sql/workbench/contrib/objectExplorer/browser/objectExplorerViewTreeShim';
import { OEShimService, IOEShimService } from 'sql/workbench/services/objectExplorer/browser/objectExplorerViewTreeShim';
import { IObjectExplorerService, ObjectExplorerService } from 'sql/workbench/services/objectExplorer/browser/objectExplorerService';
import { IAngularEventingService } from 'sql/platform/angularEventing/browser/angularEventingService';
import { AngularEventingService } from 'sql/platform/angularEventing/browser/angularEventingServiceImpl';
@@ -390,7 +390,7 @@ import 'sql/workbench/contrib/dataExplorer/browser/nodeActions.common.contributi
// {{SQL CARBON EDIT}}
//editor replacement
import 'sql/workbench/common/editorReplacer.contribution';
import 'sql/workbench/contrib/editorReplacement/common/editorReplacer.contribution';
// tasks
import 'sql/workbench/contrib/tasks/browser/tasks.contribution';
@@ -443,7 +443,7 @@ import 'sql/workbench/contrib/dashboard/browser/containers/dashboardModelViewCon
import 'sql/workbench/contrib/dashboard/browser/core/dashboardTab.contribution';
// Model-based Views
import 'sql/workbench/browser/modelComponents/components.contribution';
import 'sql/workbench/contrib/modelView/browser/components.contribution';
import 'sql/workbench/browser/modelComponents/modelViewEditor.contribution';
// notebooks

View File

@@ -19,7 +19,6 @@ import 'vs/workbench/workbench.common.main';
//#region --- workbench (desktop main)
import 'sql/setup'; // {{SQL CARBON EDIT}}
import 'vs/workbench/electron-browser/desktop.contribution';
import 'vs/workbench/electron-browser/desktop.main';