From 0fd3b25ccd328fa3eeed060c2c7e7d033073ffe0 Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Tue, 5 May 2020 13:21:26 -0700 Subject: [PATCH] remove table setActive (#10256) * remove setActive method * another place --- src/sql/base/browser/ui/table/table.ts | 4 ---- .../workbench/contrib/editData/browser/editDataGridPanel.ts | 2 +- .../workbench/contrib/editData/browser/gridParentComponent.ts | 4 ++-- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/sql/base/browser/ui/table/table.ts b/src/sql/base/browser/ui/table/table.ts index 9ec5095480..eee4fb5d24 100644 --- a/src/sql/base/browser/ui/table/table.ts +++ b/src/sql/base/browser/ui/table/table.ts @@ -230,10 +230,6 @@ export class Table extends Widget implements IDisposa this._grid.setActiveCell(row, cell); } - setActive(): void { - this._grid.setActiveCell(0, 1); - } - get activeCell(): Slick.Cell | null { return this._grid.getActiveCell(); } diff --git a/src/sql/workbench/contrib/editData/browser/editDataGridPanel.ts b/src/sql/workbench/contrib/editData/browser/editDataGridPanel.ts index cdcd337bd5..47bb3b607f 100644 --- a/src/sql/workbench/contrib/editData/browser/editDataGridPanel.ts +++ b/src/sql/workbench/contrib/editData/browser/editDataGridPanel.ts @@ -453,7 +453,7 @@ export class EditDataGridPanel extends GridParentComponent { private setActive() { if (this.firstRender && this.table) { - this.table.setActive(); + this.table.setActiveCell(0, 1); this.firstRender = false; } } diff --git a/src/sql/workbench/contrib/editData/browser/gridParentComponent.ts b/src/sql/workbench/contrib/editData/browser/gridParentComponent.ts index 31c7d17df5..3879e4753c 100644 --- a/src/sql/workbench/contrib/editData/browser/gridParentComponent.ts +++ b/src/sql/workbench/contrib/editData/browser/gridParentComponent.ts @@ -415,7 +415,7 @@ export abstract class GridParentComponent extends Disposable { return (gridIndex: number) => { self.activeGrid = gridIndex; let grid = self.table; - grid.setActive(); + grid.setActiveCell(0, 1); grid.setSelectedRows(true); }; } @@ -438,7 +438,7 @@ export abstract class GridParentComponent extends Disposable { } setTimeout(() => { self.resizeGrids(); - self.table.setActive(); + self.table.setActiveCell(0, 1); }); }