ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-17 17:22:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

data workspace review feedback implementation (#12489)

Browse Source 
* add a view to handle no workspace scenario

* text update

* project type filter improvement

* fix the project level context menu issue

* update strings
This commit is contained in:
Alan Ren
2020-09-21 10:22:21 -07:00
committed by GitHub
parent 9e29c7ab19
commit 1054164533
9 changed files with 42 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
extensions/sql-database-projects/src/controllers/projectController.ts
View File

@@ -29,6 +29,7 @@ import { BuildHelper } from '../tools/buildHelper';
import { PublishProfile, load } from '../models/publishProfile/publishProfile';
import { AddDatabaseReferenceDialog } from '../dialogs/addDatabaseReferenceDialog';
import { ISystemDatabaseReferenceSettings, IDacpacReferenceSettings, IProjectReferenceSettings } from '../models/IDatabaseReferenceSettings';
import { WorkspaceTreeItem } from 'dataworkspace';
/**
* Controller for managing project lifecycle
@@ -188,7 +189,7 @@ export class ProjectsController {
* @returns path of the built dacpac
*/
public async buildProject(project: Project): Promise<string>;
public async buildProject(context: Project | BaseProjectTreeItem): Promise<string | undefined> {
public async buildProject(context: Project | BaseProjectTreeItem | WorkspaceTreeItem): Promise<string | undefined> {
const project: Project = this.getProjectFromContext(context);
// Check mssql extension for project dlls (tracking issue #10273)
@@ -564,7 +565,11 @@ export class ProjectsController {
}
}
private getProjectFromContext(context: Project | BaseProjectTreeItem) {
private getProjectFromContext(context: Project | BaseProjectTreeItem | WorkspaceTreeItem) {
if ('element' in context) {
return context.element.project;
}
if (context instanceof Project) {
return context;
}