Update vscode-nls in notebook and samples, plus fix samples compilation (#4203)

- Upate vscode-nls to 4.0.0 in notebook extension. Should be fix for Insiders build failure due to localization package failing
- Updated samples to remove as vscode-nls if not needed, or update if still needed
- Updated samples using `npm audit fix`
- Fixed compile errors in all the samples

samples/sp_whoIsActive/package-lock.json

@@ -27,12 +27,6 @@
                 "through2": "^2.0.3"
             }
         },
-        "@types/handlebars": {
-            "version": "4.0.40",
-            "resolved": "https://registry.npmjs.org/@types/handlebars/-/handlebars-4.0.40.tgz",
-            "integrity": "sha512-sGWNtsjNrLOdKha2RV1UeF8+UbQnPSG7qbe5wwbni0mw4h2gHXyPFUMOC+xwGirIiiydM/HSqjDO4rk6NFB18w==",
-            "dev": true
-        },
         "@types/mocha": {
             "version": "2.2.48",
             "resolved": "https://registry.npmjs.org/@types/mocha/-/mocha-2.2.48.tgz",
@@ -7412,11 +7406,6 @@
                 }
             }
         },
-        "vscode-nls": {
-            "version": "2.0.2",
-            "resolved": "https://registry.npmjs.org/vscode-nls/-/vscode-nls-2.0.2.tgz",
-            "integrity": "sha1-gIUiOAhEuK0VNJmvXDsDkhrqAto="
-        },
         "vso-node-api": {
             "version": "6.5.0",
             "resolved": "https://registry.npmjs.org/vso-node-api/-/vso-node-api-6.5.0.tgz",

samples/sp_whoIsActive/package.json

@@ -6,7 +6,7 @@
     "publisher": "Microsoft",
     "preview": true,
     "engines": {
-        "vscode": "^1.17.0",
+        "vscode": "^1.26.0",
         "sqlops": "*"
     },
     "icon": "images/sqlserver.png",
@@ -247,11 +247,9 @@
         "fs-extra": "^5.0.0",
         "handlebars": "^4.0.11",
         "openurl": "^1.1.1",
-        "vscode-nls": "2.0.2",
         "sqlops": "github:anthonydresser/sqlops-extension-sqlops"
     },
     "devDependencies": {
-        "@types/handlebars": "^4.0.11",
         "@types/mocha": "^2.2.42",
         "@types/node": "^7.0.43",
         "child-process-promise": "^2.2.1",
@@ -266,7 +264,7 @@
         "tslint": "^3.14.0",
         "typemoq": "^2.1.0",
         "typescript": "^2.6.1",
-        "vscode": "^1.1.6",
-        "vsce": "1.36.2"
+        "vsce": "1.36.2",
+        "vscode": "^1.1.6"
     }
 }

samples/sp_whoIsActive/src/controllers/mainController.ts

@@ -50,4 +50,4 @@ export default class MainController extends ControllerBase {
             });
         });
     }
-}
+}