Update vscode-nls in notebook and samples, plus fix samples compilation (#4203)

- Upate vscode-nls to 4.0.0 in notebook extension. Should be fix for Insiders build failure due to localization package failing
- Updated samples to remove as vscode-nls if not needed, or update if still needed
- Updated samples using `npm audit fix`
- Fixed compile errors in all the samples

samples/sqlservices/package.json

@@ -88,25 +88,26 @@
         "postinstall": "node ./node_modules/vscode/bin/install && node ./node_modules/sqlops/bin/install && gulp copytypings"
     },
     "dependencies": {
-        "vscode-nls": "^3.2.2",
         "fs-extra": "^5.0.0",
-        "handlebars": "^4.0.11"
+        "handlebars": "^4.0.11",
+        "vscode-nls": "^4.0.0"
     },
     "devDependencies": {
         "@types/node": "^7.0.43",
+        "braces": "^2.3.2",
         "child-process-promise": "^2.2.1",
         "del": "^3.0.0",
         "gulp": "^4.0.0",
         "gulp-color": "0.0.1",
-        "gulp-sourcemaps": "^2.6.4",
+        "gulp-sourcemaps": "^2.6.5",
         "gulp-tslint": "^6.0.2",
         "gulp-typescript": "^3.2.4",
         "sqlops": "github:anthonydresser/sqlops-extension-sqlops",
         "tslint": "^3.14.0",
         "typescript": "^2.6.1",
-        "vscode": "^1.1.18",
-        "@types/handlebars": "^4.0.11",
-        "vsce": "1.36.2"
+        "url-parse": "^1.4.4",
+        "vsce": "^1.57.1",
+        "vscode": "^1.1.30"
     },
     "repository": {
         "type": "git",

samples/sqlservices/src/controllers/mainController.ts

@@ -148,7 +148,8 @@ export default class MainController implements vscode.Disposable {
 
 		await view.initializeModel(formWrapper);
 	}
-	private async getTabContent(view: sqlops.ModelView, customButton1: sqlops.window.Button, customButton2: sqlops.window.Button, componentWidth: number | string): Promise<void> {
+	private async getTabContent(view: sqlops.ModelView, customButton1: sqlops.window.Button, customButton2: sqlops.window.Button, componentWidth: number | string
+	): Promise<void> {
 		let inputBox = view.modelBuilder.inputBox()
 			.withProperties({
 				multiline: true,
@@ -181,8 +182,6 @@ export default class MainController implements vscode.Disposable {
 				label: '-'
 
 			}).component();
-		let button2 = view.modelBuilder.button()
-			.component();
 		button.onDidClick(e => {
 			backupFilesInputBox.value = 'Button clicked';
 		});
@@ -209,7 +208,7 @@ export default class MainController implements vscode.Disposable {
 				name: 'radioButtonOptions',
 				label: 'Option 1',
 				checked: true
-				//width: 300
+				// width: 300
 			}).component();
 		let radioButton2 = view.modelBuilder.radioButton()
 			.withProperties({

samples/sqlservices/src/controllers/treeDataProvider.ts

@@ -255,7 +255,7 @@ export class TreeNode implements sqlops.TreeComponentItem {
 export class TreeDataProvider implements sqlops.TreeComponentDataProvider<TreeNode> {
 		private _onDidChangeTreeData = new vscode.EventEmitter<TreeNode>();
 		constructor(private _root: TreeNode) {
-			if(this._root) {
+			if (this._root) {
 				this._root.onTreeChange(node => {
 					this._onDidChangeTreeData.fire(node);
 				});

samples/sqlservices/tslint.json

@@ -18,7 +18,6 @@
       true,
       "tabs"
     ],
-    "interface-name": true,
     "jsdoc-format": true,
     "label-position": true,
     "label-undefined": true,
@@ -36,7 +35,6 @@
     "no-console": [
       true,
       "debug",
-      "info",
       "time",
       "timeEnd",
       "trace"
@@ -50,7 +48,6 @@
     "no-eval": true,
     "no-inferrable-types": false,
     "no-internal-module": true,
-    "no-null-keyword": true,
     "no-require-imports": false,
     "no-shadowed-variable": true,
     "no-string-literal": false,