From 1231be124a7d67839d3f2ca4313b74c1f8939f63 Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Wed, 16 Jun 2021 12:22:00 -0700 Subject: [PATCH] Add aria-label to kube config input box (#15743) --- extensions/arc/src/test/ui/components/filePicker.test.ts | 2 +- extensions/arc/src/ui/components/filePicker.ts | 5 ++++- extensions/arc/src/ui/dialogs/connectControllerDialog.ts | 3 ++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/extensions/arc/src/test/ui/components/filePicker.test.ts b/extensions/arc/src/test/ui/components/filePicker.test.ts index 72e80e10fd..7810c5452a 100644 --- a/extensions/arc/src/test/ui/components/filePicker.test.ts +++ b/extensions/arc/src/test/ui/components/filePicker.test.ts @@ -18,7 +18,7 @@ const newFileUri = vscode.Uri.file(path.join('path', 'to', 'new', '.kube', 'conf describe('filePicker', function (): void { beforeEach(async () => { const { modelBuilderMock } = createModelViewMock(); - filePicker = new FilePicker(modelBuilderMock.object, initialPath, (_disposable) => { }); + filePicker = new FilePicker(modelBuilderMock.object, initialPath, (_disposable) => { }, ''); }); afterEach(() => { diff --git a/extensions/arc/src/ui/components/filePicker.ts b/extensions/arc/src/ui/components/filePicker.ts index 310f18bd05..9a5610d1b5 100644 --- a/extensions/arc/src/ui/components/filePicker.ts +++ b/extensions/arc/src/ui/components/filePicker.ts @@ -18,12 +18,15 @@ export class FilePicker { public readonly filePickerButton: azdata.ButtonComponent; constructor( modelBuilder: azdata.ModelBuilder, - initialPath: string, onNewDisposableCreated: (disposable: vscode.Disposable) => void + initialPath: string, + onNewDisposableCreated: (disposable: vscode.Disposable) => void, + ariaLabel: string ) { const buttonWidth = 80; this.filePathInputBox = modelBuilder.inputBox() .withProperties({ value: initialPath, + ariaLabel: ariaLabel, width: 350 }).component(); diff --git a/extensions/arc/src/ui/dialogs/connectControllerDialog.ts b/extensions/arc/src/ui/dialogs/connectControllerDialog.ts index f3bf1dcc62..717e0a5d80 100644 --- a/extensions/arc/src/ui/dialogs/connectControllerDialog.ts +++ b/extensions/arc/src/ui/dialogs/connectControllerDialog.ts @@ -96,7 +96,8 @@ abstract class ControllerDialogBase extends InitializingComponent { this.kubeConfigInputBox = new FilePicker( this.modelBuilder, controllerInfo?.kubeConfigFilePath || getDefaultKubeConfigPath(), - (disposable) => this._toDispose.push(disposable) + (disposable) => this._toDispose.push(disposable), + loc.controllerKubeConfig ); this.modelBuilder.inputBox() .withProps({