Feature/agent finishes (#1149)

* added icons for steps and fixed bugs in jobs view page

* put svgs in common folder

* added steps header logo

* added full path for import

* changed codes to text

* removed cat id, changed bools to yes/no and fixed steps theme

* localized the strings

* set the jobs table column widths

* added indicators for failure, unknown and canceled jobs in jobs view

* fixed jobs panel style and jobs view scrolling

* fixed jobs view page styling

* fixed job history tree size rows

* made error messages copy-able

* made job history tree work with keyboard
This commit is contained in:
Aditya Bist
2018-04-17 16:45:22 -07:00
committed by GitHub
parent b9c877a109
commit 134f76c17f
19 changed files with 273 additions and 138 deletions

View File

@@ -28,20 +28,14 @@ import { OEAction } from 'sql/parts/objectExplorer/viewlet/objectExplorerActions
import { Builder, $, withElementById } from 'vs/base/browser/builder';
import { AgentJobHistoryInfo } from 'sqlops';
import { Agent } from 'vs/base/node/request';
import { IKeyboardEvent } from 'vs/base/browser/keyboardEvent';
import { JobHistoryComponent } from './jobHistory.component';
export class JobHistoryRow {
runDate: string;
runStatus: string;
instanceID: number;
rowID: string = generateUuid();
public static convertToStatusString(status: number): string {
switch(status) {
case(1): return 'Succeeded';
case(0): return 'Failed';
default: return 'Unknown';
}
}
}
// Empty class just for tree input
@@ -56,10 +50,6 @@ export class JobHistoryController extends TreeDefaults.DefaultController {
return true;
}
public onContextMenu(tree: tree.ITree, element: JobHistoryRow, event: tree.ContextMenuEvent): boolean {
return true;
}
public set jobHistories(value: AgentJobHistoryInfo[]) {
this._jobHistories = value;
}
@@ -68,6 +58,17 @@ export class JobHistoryController extends TreeDefaults.DefaultController {
return this._jobHistories;
}
public onKeyDownWrapper(tree: tree.ITree, event: IKeyboardEvent): boolean {
if (event.code === 'ArrowDown' || event.keyCode === 40) {
return super.onDown(tree, event);
} else if (event.code === 'ArrowUp' || event.keyCode === 38) {
return super.onUp(tree, event);
} else {
event.preventDefault();
event.stopPropagation();
return true;
}
}
}
export class JobHistoryDataSource implements tree.IDataSource {
@@ -119,7 +120,7 @@ export class JobHistoryRenderer implements tree.IRenderer {
private _statusIcon: HTMLElement;
public getHeight(tree: tree.ITree, element: JobHistoryRow): number {
return 22;
return 30;
}
public getTemplateId(tree: tree.ITree, element: JobHistoryRow | JobHistoryModel): string {