From 14ea5e9dd7ad43dd537455b3fb5d6dd4c35a84b9 Mon Sep 17 00:00:00 2001 From: Christopher Suh Date: Wed, 22 Mar 2023 12:57:49 -0700 Subject: [PATCH] fix logic (#22405) --- .../browser/accountManagementService.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/sql/workbench/services/accountManagement/browser/accountManagementService.ts b/src/sql/workbench/services/accountManagement/browser/accountManagementService.ts index 8fad515d2b..136df0f505 100644 --- a/src/sql/workbench/services/accountManagement/browser/accountManagementService.ts +++ b/src/sql/workbench/services/accountManagement/browser/accountManagementService.ts @@ -321,18 +321,19 @@ export class AccountManagementService implements IAccountManagementService { // Step 3) Update the account cache and fire an event return this.doWithProvider(accountKey.providerId, async provider => { const result = await this._accountStore.remove(accountKey); + let indexToRemove: number = provider.accounts.findIndex(account => { + return account.key.accountId === accountKey.accountId; + }); await provider.provider.clear(accountKey); if (!result) { return result; } - let indexToRemove: number = provider.accounts.findIndex(account => { - return account.key.accountId === accountKey.accountId; - }); - if (indexToRemove >= 0) { provider.accounts.splice(indexToRemove, 1); this.fireAccountListUpdate(provider, false); + } else { + this._logService.error(`Error when removing an account: ${accountKey.accountId} could not find account in provider list.`); } return result; });