CMS fit and finish (#5542)

* cms connections dont save

* added value to enum

* remove refresh and update provider name for cms

* removed ownerUri from saved connection and contributed to array

* removed owneruri

* ownerUri not needed any more

* removed AAD from cms

* initial review

* changed comments

* add back saveProfile option for connectionProfile

* review fixes and other UI improvements

* fixed auth

* added cms integration tests

* added constants

* removed utils from apiwrapper

* changed connection type name

* review comments

* clearer code and addressed reviews
This commit is contained in:
Aditya Bist
2019-05-31 11:14:37 -07:00
committed by GitHub
parent fa52478ffa
commit 1773dede25
27 changed files with 546 additions and 278 deletions

View File

@@ -24,8 +24,8 @@
"type": "object",
"title": "%cms.title%",
"properties": {
"cms.cmsServers": {
"type": "object"
"centralManagementServers.servers": {
"type": "array"
}
}
},
@@ -518,7 +518,7 @@
{
"command": "cms.resource.deleteRegisteredServer",
"title": "%cms.resource.deleteRegisteredServer.title%",
"when": "viewItem == cms.resource.itemType.registeredServer"
"when": "viewItem == cms.resource.itemType.databaseServer"
},
{
"command": "cms.resource.addRegisteredServer",
@@ -536,18 +536,8 @@
"when": "viewItem == cms.resource.itemType.serverGroup"
},
{
"command": "cms.resource.refreshServerGroup",
"title": "%cms.resource.refreshServerGroup.title%",
"when": "viewItem == cms.resource.itemType.serverGroup",
"icon": {
"light": "resources/light/refresh.svg",
"dark": "resources/dark/refresh_inverse.svg"
}
},
{
"command": "cms.resource.refreshCmsServer",
"title": "%cms.resource.refreshCmsServer.title%",
"when": "viewItem == cms.resource.itemType.cmsNodeContainer",
"command": "cms.resource.refresh",
"title": "%cms.resource.refresh.title%",
"icon": {
"light": "resources/light/refresh.svg",
"dark": "resources/dark/refresh_inverse.svg"
@@ -585,7 +575,7 @@
"view/item/context": [
{
"command": "cms.resource.deleteRegisteredServer",
"when": "viewItem == cms.resource.itemType.registeredServer",
"when": "viewItem == cms.resource.itemType.databaseServer",
"group": "navigation@2"
},
{
@@ -600,7 +590,7 @@
},
{
"command": "cms.resource.addRegisteredServer",
"when": "viewItem == cms.resource.itemType.cmsNodeContainer",
"when": "viewItem == cms.resource.itemType.databaseServerContainer",
"group": "navigation@10"
},
{
@@ -610,22 +600,22 @@
},
{
"command": "cms.resource.addServerGroup",
"when": "viewItem == cms.resource.itemType.cmsNodeContainer",
"when": "viewItem == cms.resource.itemType.databaseServerContainer",
"group": "navigation@10"
},
{
"command": "cms.resource.refreshServerGroup",
"command": "cms.resource.refresh",
"when": "viewItem == cms.resource.itemType.serverGroup",
"group": "navigation@10"
},
{
"command": "cms.resource.refreshCmsServer",
"when": "viewItem == cms.resource.itemType.cmsNodeContainer",
"command": "cms.resource.refresh",
"when": "viewItem == cms.resource.itemType.databaseServerContainer",
"group": "navigation@10"
},
{
"command": "cms.resource.deleteCmsServer",
"when": "viewItem == cms.resource.itemType.cmsNodeContainer",
"when": "viewItem == cms.resource.itemType.databaseServerContainer",
"group": "navigation@10"
}
]