Alanren/fixfor1782 (#2247)

* fix for issue #1782, refresh the cached data

* pick up the latest version of slickgrid and tools service
This commit is contained in:
Alan Ren
2018-08-16 16:54:07 -07:00
committed by GitHub
parent db817a7192
commit 19c08fe0eb
4 changed files with 8 additions and 5 deletions

View File

@@ -1,6 +1,6 @@
{ {
"downloadUrl": "https://github.com/Microsoft/sqltoolsservice/releases/download/v{#version#}/microsoft.sqltools.servicelayer-{#fileName#}", "downloadUrl": "https://github.com/Microsoft/sqltoolsservice/releases/download/v{#version#}/microsoft.sqltools.servicelayer-{#fileName#}",
"version": "1.5.0-alpha.22", "version": "1.5.0-alpha.27",
"downloadFileNames": { "downloadFileNames": {
"Windows_86": "win-x86-netcoreapp2.1.zip", "Windows_86": "win-x86-netcoreapp2.1.zip",
"Windows_64": "win-x64-netcoreapp2.1.zip", "Windows_64": "win-x64-netcoreapp2.1.zip",

View File

@@ -34,7 +34,7 @@
"@angular/router": "~4.1.3", "@angular/router": "~4.1.3",
"@angular/upgrade": "~4.1.3", "@angular/upgrade": "~4.1.3",
"angular2-grid": "2.0.6", "angular2-grid": "2.0.6",
"angular2-slickgrid": "github:Microsoft/angular2-slickgrid#1.4.1", "angular2-slickgrid": "github:Microsoft/angular2-slickgrid#1.4.3",
"applicationinsights": "0.18.0", "applicationinsights": "0.18.0",
"chart.js": "^2.6.0", "chart.js": "^2.6.0",
"fast-plist": "0.1.2", "fast-plist": "0.1.2",

View File

@@ -457,9 +457,11 @@ export class EditDataComponent extends GridParentComponent implements OnInit, On
} }
} finally { } finally {
// The operation may fail if there were no changes sent to the service to revert, // The operation may fail if there were no changes sent to the service to revert,
// so clear any existing client-side edit and refresh the table regardless // so clear any existing client-side edit and refresh on-screen data
// do not refresh the whole dataset as it will move the focus away to the first row.
//
this.currentEditCellValue = null; this.currentEditCellValue = null;
this.refreshResultsets(); this.dataSet.dataRows.resetWindowsAroundIndex(this.currentCell.row);
} }
} }
} }

View File

@@ -57,6 +57,7 @@ export interface IObservableCollection<T> {
at(index: number): T; at(index: number): T;
getRange(start: number, end: number): T[]; getRange(start: number, end: number): T[];
setCollectionChangedCallback(callback: (change: CollectionChange, startIndex: number, count: number) => void): void; setCollectionChangedCallback(callback: (change: CollectionChange, startIndex: number, count: number) => void): void;
resetWindowsAroundIndex(index: number): void;
} }
export class CancellationToken { export class CancellationToken {
private _isCanceled; private _isCanceled;
@@ -291,7 +292,7 @@ export class VirtualizedCollection<TData> implements IObservableCollection<TData
getRange(start: number, end: number): TData[]; getRange(start: number, end: number): TData[];
private getRangeFromCurrent(start, end); private getRangeFromCurrent(start, end);
private getDataFromCurrent(index); private getDataFromCurrent(index);
private resetWindowsAroundIndex(index); resetWindowsAroundIndex(index);
} }
} }
declare module 'angular2-slickgrid/out/js/virtualizedCollection' { declare module 'angular2-slickgrid/out/js/virtualizedCollection' {