ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-07 01:25:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove some TODOs mostly for styling (#23934)

Browse Source 
* Remove some TODOs mostly for styling

* Remove unused
This commit is contained in:
Karl Burtram
2023-07-19 17:56:49 -07:00
committed by GitHub
parent 760ccfdef3
commit 1addfae2e8
9 changed files with 3 additions and 118 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/vs/base/common/themables.ts
View File

@@ -38,32 +38,6 @@ export namespace ThemeIcon {
const ThemeIconIdRegex = new RegExp(`^(${iconNameExpression})(${iconModifierExpression})?$`);
// {{SQL CARBON TODO}} - do we need the edit block below
// export function asClassNameArray(icon: CSSIcon): string[] {
// if (icon instanceof Codicon) {
// return ['codicon', 'codicon-' + icon.id];
// }
// const match = cssIconIdRegex.exec(icon.id);
// if (!match) {
// return asClassNameArray(Codicon.error);
// }
// const [, id, modifier] = match;
// // {{SQL CARBON EDIT}} Modifying method to not add 'codicon' in front of sql carbon icons.
// let sqlCarbonIcons: string[] = [SqlIconId.activeConnectionsAction, SqlIconId.addServerAction, SqlIconId.addServerGroupAction, SqlIconId.serverPage];
// if (sqlCarbonIcons.includes(id)) {
// return ['codicon', id];
// // {{SQL CARBON EDIT}} End of edit
// } else {
// const classNames = ['codicon', 'codicon-' + id];
// if (modifier) {
// classNames.push('codicon-modifier-' + modifier.substr(1));
// }
// return classNames;
// }
// }
export function asClassNameArray(icon: ThemeIcon): string[] {
const match = ThemeIconIdRegex.exec(icon.id);
if (!match) {

2
src/vs/platform/extensionManagement/common/extensionGalleryService.ts
View File

@@ -1126,7 +1126,7 @@ abstract class AbstractExtensionGalleryService implements IExtensionGalleryServi
if (result) {
const r = result.results[0];
const galleryExtensions = r.extensions;
// {{SQL CARBON TODO}}
// {{SQL CARBON EDIT}}
galleryExtensions.forEach(e => sortExtensionVersions(e.versions, TargetPlatform.UNIVERSAL));
// const resultCount = r.resultMetadata && r.resultMetadata.filter(m => m.metadataType === 'ResultCount')[0]; {{SQL CARBON EDIT}} comment out for no unused
// const total = resultCount && resultCount.metadataItems.filter(i => i.name === 'TotalCount')[0].count || 0; {{SQL CARBON EDIT}} comment out for no unused

4
src/vs/workbench/services/themes/browser/workbenchThemeService.ts
View File

@@ -44,10 +44,6 @@ import { ILanguageService } from 'vs/editor/common/languages/language';
// implementation
// {{SQL CARBON TODO}} - default theme?
// const DEFAULT_COLOR_THEME_ID = 'vs sql-theme-carbon-themes-light_carbon-json'; // {{SQL CARBON EDIT}}
// const DEFAULT_LIGHT_COLOR_THEME_ID = 'vs vscode-theme-defaults-themes-light_plus-json';
const PERSISTED_OS_COLOR_SCHEME = 'osColorScheme';
const PERSISTED_OS_COLOR_SCHEME_SCOPE = StorageScope.APPLICATION; // the OS scheme depends on settings in the OS