Remove Direct connectivity mode option (#12533)

* Remove Direct connectivity mode option

* remove option completely

* fix string

extensions/arc/notebooks/arcDeployment/deploy.arc.data.controller.ipynb

@@ -188,7 +188,7 @@
                 "os.environ[\"AZDATA_PASSWORD\"] = arc_admin_password\n",
                 "if os.name == 'nt':\n",
                 "    print(f'If you don\\'t see output produced by azdata, you can run the following command in a terminal window to check the deployment status:\\n\\t {os.environ[\"AZDATA_NB_VAR_KUBECTL\"]} get pods -n {arc_data_controller_namespace}')\n",
-                "run_command(f'azdata arc dc create --connectivity-mode {arc_data_controller_connectivity_mode} -n {arc_data_controller_name} -ns {arc_data_controller_namespace} -s {arc_subscription} -g {arc_resource_group} -l {arc_data_controller_location} -sc {arc_data_controller_storage_class} --profile-name {arc_profile}')\n",
+                "run_command(f'azdata arc dc create --connectivity-mode Indirect -n {arc_data_controller_name} -ns {arc_data_controller_namespace} -s {arc_subscription} -g {arc_resource_group} -l {arc_data_controller_location} -sc {arc_data_controller_storage_class} --profile-name {arc_profile}')\n",
                 "print(f'Azure Arc Data Controller: {arc_data_controller_name} created.') "
             ],
             "metadata": {

extensions/arc/package.json

@@ -274,21 +274,6 @@
                             "westeurope",
                             "westus2"
                           ]
-                        },
-                        {
-                          "type": "options",
-                          "label": "%arc.data.controller.arc.data.controller.connectivity.mode%",
-                          "options": {
-                            "values": [
-                              "Indirect",
-                              "Direct"
-                            ],
-                            "defaultValue": "Indirect",
-                            "optionsType": "radio"
-                          },
-                          "enabled": false,
-                          "required": true,
-                          "variableName": "AZDATA_NB_VAR_ARC_DATA_CONTROLLER_CONNECTIVITY_MODE"
                         }
                       ]
                     },
@@ -484,12 +469,6 @@
                           "isEvaluated": true,
                           "defaultValue": "$(AZDATA_NB_VAR_ARC_DATA_CONTROLLER_NAME)"
                         },
-                        {
-                          "label": "%arc.data.controller.summary.data.controller.connectivity.mode%",
-                          "type": "readonly_text",
-                          "isEvaluated": true,
-                          "defaultValue": "$(AZDATA_NB_VAR_ARC_DATA_CONTROLLER_CONNECTIVITY_MODE)"
-                        },
                         {
                           "label": "%arc.data.controller.summary.subscription%",
                           "type": "readonly_text",

extensions/arc/package.nls.json

@@ -14,7 +14,6 @@
 
 	"resource.type.azure.arc.display.name": "Azure Arc data controller (preview)",
 	"resource.type.azure.arc.description": "Creates an Azure Arc data controller",
-
 	"arc.data.controller.new.wizard.title": "Create Azure Arc data controller",
 	"arc.data.controller.cluster.environment.title": "What is your target existing Kubernetes cluster environment?",
 	"arc.data.controller.select.cluster.title": "Select from existing Kubernetes clusters",
@@ -26,7 +25,6 @@
 	"arc.data.controller.project.details.description": "Select the subscription to manage deployed resources and costs. Use resource groups like folders to organize and manage all your resources.",
 	"arc.data.controller.data.controller.details.title": "Data controller details",
 	"arc.data.controller.data.controller.details.description": "Provide an Azure region and a name for your Azure Arc data controller. This name will be used to identify your Arc location for remote management and monitoring.",
-	"arc.data.controller.arc.data.controller.connectivity.mode": "Data controller connectivity mode",
 	"arc.data.controller.arc.data.controller.namespace": "Data controller namespace",
 	"arc.data.controller.arc.data.controller.namespace.validation.description": "Namespace must consist of lower case alphanumeric characters or '-', start/end with an alphanumeric character, and be 63 characters or fewer in length.",
 	"arc.data.controller.arc.data.controller.name": "Data controller name",
@@ -55,7 +53,6 @@
 	"arc.data.controller.summary.azure": "Azure",
 	"arc.data.controller.summary.subscription": "Subscription",
 	"arc.data.controller.summary.resource.group": "Resource group",
-	"arc.data.controller.summary.data.controller.connectivity.mode": "Data controller connectivity mode",
 	"arc.data.controller.summary.data.controller.name": "Data controller name",
 	"arc.data.controller.summary.data.controller.namespace": "Data controller namespace",
 	"arc.data.controller.summary.location": "Location",