check-param-names (#18189)

extensions/machine-learning/src/common/utils.ts

@@ -220,7 +220,9 @@ export function getScriptWithDBChange(currentDb: string, databaseName: string, s
 
 /**
  * Returns full name of model registration table
- * @param config config
+ * @param db
+ * @param table
+ * @param schema
  */
 export function getRegisteredModelsThreePartsName(db: string, table: string, schema: string) {
 	const dbName = doubleEscapeSingleBrackets(db);
@@ -231,7 +233,8 @@ export function getRegisteredModelsThreePartsName(db: string, table: string, sch
 
 /**
  * Returns full name of model registration table
- * @param config config object
+ * @param table
+ * @param schema
  */
 export function getRegisteredModelsTwoPartsName(table: string, schema: string) {
 	const schemaName = doubleEscapeSingleBrackets(schema);

extensions/machine-learning/src/modelManagement/deployedModelService.ts

@@ -155,7 +155,6 @@ export class DeployedModelService {
 	/**
 	 * Verifies if the given table name is valid to be used as import table. If table doesn't exist returns true to create new table
 	 * Otherwise verifies the schema and returns true if the schema is supported
-	 * @param connection database connection
 	 * @param table config table name
 	 */
 	public async verifyConfigTable(table: DatabaseTable): Promise<boolean> {

extensions/machine-learning/src/modelManagement/queries.ts

@@ -29,8 +29,7 @@ export function getDeployedModelsQuery(table: DatabaseTable): string {
 
 /**
  * Verifies config table has the expected schema
- * @param databaseName
- * @param tableName
+ * @param table
  */
 export function getConfigTableVerificationQuery(table: DatabaseTable): string {
 	let tableName = table.tableName;

extensions/machine-learning/src/packageManagement/packageManagementService.ts

@@ -45,7 +45,6 @@ export class PackageManagementService {
 	/**
 	 * Updates external script config
 	 * @param connection SQL Connection
-	 * @param enable if true external script will be enabled
 	 */
 	public async enableExternalScriptConfig(connection: azdata.connection.ConnectionProfile): Promise<boolean> {
 		let current = await this._queryRunner.isMachineLearningServiceEnabled(connection);

extensions/machine-learning/src/packageManagement/sqlPythonPackageManageProvider.ts

@@ -57,8 +57,9 @@ export class SqlPythonPackageManageProvider extends SqlPackageManageProviderBase
 
 	/**
 	 * Execute a script to install or uninstall a python package inside current SQL Server connection
-	 * @param packageDetails Packages to install or uninstall
 	 * @param scriptMode can be 'install' or 'uninstall'
+	 * @param packageDetails Packages to install or uninstall
+	 * @param databaseName
 	 */
 	protected async executeScripts(scriptMode: ScriptMode, packageDetails: nbExtensionApis.IPackageDetails, databaseName: string): Promise<void> {
 		let connection = await this.getCurrentConnection();

extensions/machine-learning/src/packageManagement/sqlRPackageManageProvider.ts

@@ -60,8 +60,9 @@ export class SqlRPackageManageProvider extends SqlPackageManageProviderBase impl
 
 	/**
 	 * Execute a script to install or uninstall a r package inside current SQL Server connection
-	 * @param packageDetails Packages to install or uninstall
 	 * @param scriptMode can be 'install' or 'uninstall'
+	 * @param packageDetails Packages to install or uninstall
+	 * @param databaseName
 	 */
 	protected async executeScripts(scriptMode: ScriptMode, packageDetails: nbExtensionApis.IPackageDetails, databaseName: string): Promise<void> {
 		let connection = await this.getCurrentConnection();

extensions/machine-learning/src/views/models/modelManagementController.ts

@@ -47,6 +47,7 @@ export class ModelManagementController extends ControllerBase {
 
 	/**
 	 * Opens the dialog for model import
+	 * @param importTable
 	 * @param parent parent if the view is opened from another view
 	 * @param controller controller
 	 * @param apiWrapper apiWrapper

extensions/machine-learning/src/views/models/modelViewBase.ts

@@ -176,7 +176,7 @@ export abstract class ModelViewBase extends ViewBase {
 
 	/**
 	 * registers local model
-	 * @param localFilePath local file path
+	 * @param models
 	 */
 	public async importLocalModel(models: ModelViewData[]): Promise<void> {
 		return await this.sendDataRequest(RegisterLocalModelEventName, models);
@@ -192,7 +192,7 @@ export abstract class ModelViewBase extends ViewBase {
 
 	/**
 	 * download azure model
-	 * @param args azure resource
+	 * @param resource azure resource
 	 */
 	public async downloadAzureModel(resource: AzureModelResource | undefined): Promise<string> {
 		return await this.sendDataRequest(DownloadAzureModelEventName, resource);
@@ -207,7 +207,7 @@ export abstract class ModelViewBase extends ViewBase {
 
 	/**
 	 * registers azure model
-	 * @param args azure resource
+	 * @param models
 	 */
 	public async importAzureModel(models: ModelViewData[]): Promise<void> {
 		return await this.sendDataRequest(RegisterAzureModelEventName, models);
@@ -229,7 +229,9 @@ export abstract class ModelViewBase extends ViewBase {
 
 	/**
 	 * registers azure model
-	 * @param args azure resource
+	 * @param model
+	 * @param filePath
+	 * @param params
 	 */
 	public async generatePredictScript(model: ImportedModel | undefined, filePath: string | undefined, params: PredictParameters | undefined): Promise<void> {
 		const args: PredictModelEventArgs = Object.assign({}, params, {

extensions/machine-learning/src/views/models/modelsDetailsTableComponent.ts

@@ -111,7 +111,6 @@ export class ModelsDetailsTableComponent extends ModelViewBase implements IDataC
 
 	/**
 	 * Load data in the component
-	 * @param workspaceResource Azure workspace
 	 */
 	public async loadData(): Promise<void> {
 

extensions/machine-learning/src/views/models/prediction/columnsTable.ts

@@ -158,7 +158,8 @@ export class ColumnsTable extends ModelViewBase implements IDataComponent<Predic
 
 	/**
 	 * Load data in the component
-	 * @param workspaceResource Azure workspace
+	 * @param modelParameters
+	 * @param table
 	 */
 	public async loadInputs(modelParameters: ModelParameters | undefined, table: DatabaseTable): Promise<void> {
 		await this.onLoading();