ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-12 19:18:32 -05:00
Code Issues Packages Projects Releases Wiki Activity

check-param-names (#18189)

Browse Source
This commit is contained in:
Charles Gagnon
2022-01-31 12:39:22 -08:00
committed by GitHub
parent 7149bbd591
commit 1c9ba64ee0
47 changed files with 96 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
extensions/notebook/src/book/bookModel.ts
View File

@@ -345,6 +345,7 @@ export class BookModel {
/**
* Recursively parses out a section of a Jupyter Book.
* @param version
* @param section The input data to parse
*/
public parseJupyterSections(version: string, section: any[]): JupyterBookSection[] {

6
extensions/notebook/src/book/bookTocManager.ts
View File

@@ -325,7 +325,7 @@ export class BookTocManager implements IBookTocManager {
* Moves a section to a book top level or another book's section. If there's a target section we add the the targetSection directory if it has one and append it to the
* notebook's path. The overwrite option is set to false to prevent any issues with duplicated file names.
* @param section The section that's been moved.
* @param book The target book.
* @param bookItem The target book.
*/
async moveSectionFiles(section: BookTreeItem, bookItem: BookTreeItem): Promise<void> {
const uri = path.posix.join(path.posix.sep, path.relative(section.rootContentPath, section.book.contentPath));
@@ -369,8 +369,8 @@ export class BookTocManager implements IBookTocManager {
/**
* Moves a file to a book top level or a book's section. If there's a target section we add the the targetSection directory if it has one and append it to the
* files's path. The overwrite option is set to false to prevent any issues with duplicated file names.
* @param element Notebook, Markdown File, or book's notebook that will be added to the book.
* @param targetBook Book that will be modified.
* @param file Notebook, Markdown File, or book's notebook that will be added to the book.
* @param book Book that will be modified.
*/
async moveFile(file: BookTreeItem, book: BookTreeItem): Promise<void> {
const rootPath = book.rootContentPath;

2
extensions/notebook/src/book/bookTreeView.ts
View File

@@ -330,7 +330,7 @@ export class BookTreeViewProvider implements vscode.TreeDataProvider<BookTreeIte
* were able to successfully parse it.
* @param bookPath The path to the book folder to create the model for
* @param isNotebook A boolean value to know we are creating a model for a notebook or a book
* @param notebookBookRoot For pinned notebooks we need to know if the notebook is part of a book or it's a standalone notebook
* @param notebookDetails
*/
private async createAndAddBookModel(bookPath: string, isNotebook: boolean, notebookDetails?: IPinnedNotebook): Promise<void> {
if (!this.books.find(x => x.bookPath === bookPath)) {

2
extensions/notebook/src/intellisense/text.ts
View File

@@ -45,8 +45,6 @@ export function jsIndexToCharIndex(jsIdx: number, text: string): number {
/**
* Get the diff between pure character count and JS-based count with 2 chars per surrogate pair.
*
* @param charIdx - The index in unicode characters
*
* @param text - The text in which the offset is calculated
*
* @returns The js-native index