check-param-names (#18189)

This commit is contained in:
Charles Gagnon
2022-01-31 12:39:22 -08:00
committed by GitHub
parent 7149bbd591
commit 1c9ba64ee0
47 changed files with 96 additions and 80 deletions

View File

@@ -73,7 +73,7 @@ export async function setLocalAppSetting(projectFolder: string, key: string, val
/**
* Gets the Azure Functions project that contains the given file if the project is open in one of the workspace folders
* @param filePath file that the containing project needs to be found for
* @param fileUri file that the containing project needs to be found for
* @returns uri of project or undefined if project couldn't be found
*/
export async function getAFProjectContainingFile(fileUri: vscode.Uri): Promise<vscode.Uri | undefined> {

View File

@@ -150,9 +150,7 @@ export class ProjectsController {
/**
* Creates a new folder with the project name in the specified location, and places the new .sqlproj inside it
* @param newProjName
* @param folderUri
* @param projectGuid
* @param creationParams
*/
public async createNewProject(creationParams: NewProjectParams): Promise<string> {
TelemetryReporter.createActionEvent(TelemetryViews.ProjectController, TelemetryActions.createNewProject)
@@ -266,7 +264,8 @@ export class ProjectsController {
/**
* Publishes a project to docker container
* @param treeNode a treeItem in a project's hierarchy, to be used to obtain a Project
* @param context a treeItem in a project's hierarchy, to be used to obtain a Project or the Project itself
* @param deployProfile
*/
public async publishToDockerContainer(context: Project | dataworkspace.WorkspaceTreeItem, deployProfile: IDeployProfile): Promise<void> {
const project: Project = this.getProjectFromContext(context);
@@ -795,7 +794,7 @@ export class ProjectsController {
/**
* Reloads the given project. Throws an error if given project is not a valid open project.
* @param projectFileUri the uri of the project to be reloaded
* @param context
*/
public async reloadProject(context: dataworkspace.WorkspaceTreeItem): Promise<void> {
const project = this.getProjectFromContext(context);

View File

@@ -21,7 +21,6 @@ interface DbServerValues {
/**
* Create flow for adding a database reference using only VS Code-native APIs such as QuickPick
* @param connectionInfo Optional connection info to use instead of prompting the user for a connection
*/
export async function addDatabaseReferenceQuickpick(project: Project): Promise<AddDatabaseReferenceSettings | undefined> {

View File

@@ -740,7 +740,7 @@ export class Project implements ISqlProject {
/**
* Set the target platform of the project
* @param newTargetPlatform compat level of project
* @param compatLevel compat level of project
*/
public async changeTargetPlatform(compatLevel: string): Promise<void> {
if (this.getProjectTargetVersion() !== compatLevel) {
@@ -863,8 +863,6 @@ export class Project implements ISqlProject {
/**
* Adds reference to a dacpac to the project
* @param uri Uri of the dacpac
* @param databaseName name of the database
*/
public async addDatabaseReference(settings: IDacpacReferenceSettings): Promise<void> {
const databaseReferenceEntry = new DacpacReferenceProjectEntry(settings);
@@ -879,8 +877,6 @@ export class Project implements ISqlProject {
/**
* Adds reference to a another project in the workspace
* @param uri Uri of the dacpac
* @param databaseName name of the database
*/
public async addProjectReference(settings: IProjectReferenceSettings): Promise<void> {
const projectReferenceEntry = new SqlProjectReferenceProjectEntry(settings);

View File

@@ -22,7 +22,7 @@ export class SqlDatabaseProjectProvider implements dataworkspace.IProjectProvide
/**
* Gets the project tree data provider
* @param projectFile The project file Uri
* @param projectFilePath The project file Uri
*/
async getProjectTreeDataProvider(projectFilePath: vscode.Uri): Promise<vscode.TreeDataProvider<BaseProjectTreeItem>> {
const provider = new SqlDatabaseProjectTreeViewProvider();

View File

@@ -38,7 +38,7 @@ export class PackageHelper {
/**
* Runs dotnet add package to add a package reference to the specified project. If the project already has a package reference
* for this package version, the project file won't get updated
* @param projectPath uri of project to add package to
* @param projectUri uri of project to add package to
* @param packageName name of package
* @param packageVersion optional version of package. If none, latest will be pulled in
*/
@@ -53,7 +53,7 @@ export class PackageHelper {
/**
* Adds specified package to Azure Functions project the specified file is a part of
* @param filePath uri of file to find the containing AF project of to add package reference to
* @param fileUri uri of file to find the containing AF project of to add package reference to
* @param packageName package to add reference to
* @param packageVersion optional version of package. If none, latest will be pulled in
*/