Setup files for workbench/services to be strict compiled (#9168)

* setup services to be strict compiled. fix some of the issues

* fix compile

* fix compile

* revert some undefined changes
This commit is contained in:
Anthony Dresser
2020-02-19 16:07:57 -08:00
committed by GitHub
parent cec7753e3d
commit 1d0f76d26a
17 changed files with 204 additions and 158 deletions

View File

@@ -795,13 +795,9 @@ export class TabsTitleControl extends TitleControl {
// {{SQL CARBON EDIT}} -- Display the editor's tab color
if (isTab) {
const tabContainer = this.tabsContainer.children[index];
if (tabContainer instanceof HTMLElement) {
let editor = this.group.getEditors(index);
if (editor.length > 0) {
this.setEditorTabColor(editor[0], tabContainer, isActiveTab);
}
}
this.doWithTab(index!, editor!, (editor, index, tabContainer) => {
this.setEditorTabColor(editor, tabContainer, isActiveTab);
});
}
}

View File

@@ -42,7 +42,7 @@ export class TextDiffEditor extends BaseTextEditor implements ITextDiffEditor {
private diffNavigator: DiffNavigator | undefined;
private readonly diffNavigatorDisposables = this._register(new DisposableStore());
private reverseColor: boolean; // {{SQL CARBON EDIT}} add property
private reverseColor?: boolean; // {{SQL CARBON EDIT}} add property
constructor(
@ITelemetryService telemetryService: ITelemetryService,

View File

@@ -65,7 +65,7 @@ export abstract class MenubarControl extends Disposable {
// 'Terminal': IMenu; {{SQL CARBON EDIT}} - Disable unusued menus
'Window'?: IMenu;
'Help': IMenu;
// [index: string]: IMenu | undefined; {{SQL CARBON EDIT}} - Disable unusued menus
[index: string]: IMenu | undefined;
};
protected topLevelTitles: { [menu: string]: string } = {