From 1d6f48806e42b80e1fd2dcbea2d9a7135bfbb8f5 Mon Sep 17 00:00:00 2001 From: Anthony Dresser Date: Tue, 3 Sep 2019 17:17:23 -0700 Subject: [PATCH] fix index for panel push (#7035) --- src/sql/base/browser/ui/panel/panel.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/sql/base/browser/ui/panel/panel.ts b/src/sql/base/browser/ui/panel/panel.ts index ae779bf32a..93469564a7 100644 --- a/src/sql/base/browser/ui/panel/panel.ts +++ b/src/sql/base/browser/ui/panel/panel.ts @@ -190,9 +190,9 @@ export class TabbedPanel extends Disposable { })); const insertBefore = !isUndefinedOrNull(index) ? this.tabList.children.item(index) : undefined; - if (insertBefore && index) { - this._tabOrder.copyWithin(index + 1, index); - this._tabOrder[index] = tab.tab.identifier; + if (insertBefore) { + this._tabOrder.copyWithin(index! + 1, index!); + this._tabOrder[index!] = tab.tab.identifier; this.tabList.insertBefore(tabHeaderElement, insertBefore); } else { this.tabList.append(tabHeaderElement);