From 1e0b0bb21a353e0c7d364a14eb84b90c597e4e5b Mon Sep 17 00:00:00 2001 From: Karl Burtram Date: Tue, 24 Aug 2021 09:58:32 -0700 Subject: [PATCH] Fix link for Getting Started command (#16863) * Fix link for Getting Started command * Fix comment --- ...tion.ts => gettingStarted.contribution.ts} | 6 ++--- .../{releaseNotes.ts => gettingStarted.ts} | 26 +++++-------------- src/vs/workbench/workbench.desktop.main.ts | 4 +-- 3 files changed, 12 insertions(+), 24 deletions(-) rename src/sql/workbench/update/electron-browser/{releaseNotes.contribution.ts => gettingStarted.contribution.ts} (66%) rename src/sql/workbench/update/electron-browser/{releaseNotes.ts => gettingStarted.ts} (62%) diff --git a/src/sql/workbench/update/electron-browser/releaseNotes.contribution.ts b/src/sql/workbench/update/electron-browser/gettingStarted.contribution.ts similarity index 66% rename from src/sql/workbench/update/electron-browser/releaseNotes.contribution.ts rename to src/sql/workbench/update/electron-browser/gettingStarted.contribution.ts index 1b804af876..a678bfa0fc 100644 --- a/src/sql/workbench/update/electron-browser/releaseNotes.contribution.ts +++ b/src/sql/workbench/update/electron-browser/gettingStarted.contribution.ts @@ -4,10 +4,10 @@ *--------------------------------------------------------------------------------------------*/ import { IWorkbenchActionRegistry, Extensions as ActionExtensions } from 'vs/workbench/common/actions'; -import { ShowCurrentReleaseNotesAction } from 'sql/workbench/update/electron-browser/releaseNotes'; +import { ShowGettingStartedAction } from 'sql/workbench/update/electron-browser/gettingStarted'; import { SyncActionDescriptor } from 'vs/platform/actions/common/actions'; import { Registry } from 'vs/platform/registry/common/platform'; -// add product update and release notes contributions +// add getting started contributions Registry.as(ActionExtensions.WorkbenchActions) - .registerWorkbenchAction(SyncActionDescriptor.create(ShowCurrentReleaseNotesAction, ShowCurrentReleaseNotesAction.ID, ShowCurrentReleaseNotesAction.LABEL), 'Show Getting Started'); + .registerWorkbenchAction(SyncActionDescriptor.create(ShowGettingStartedAction, ShowGettingStartedAction.ID, ShowGettingStartedAction.LABEL), 'Show Getting Started'); diff --git a/src/sql/workbench/update/electron-browser/releaseNotes.ts b/src/sql/workbench/update/electron-browser/gettingStarted.ts similarity index 62% rename from src/sql/workbench/update/electron-browser/releaseNotes.ts rename to src/sql/workbench/update/electron-browser/gettingStarted.ts index 9da2de740f..cda0b3874c 100644 --- a/src/sql/workbench/update/electron-browser/releaseNotes.ts +++ b/src/sql/workbench/update/electron-browser/gettingStarted.ts @@ -6,18 +6,20 @@ import nls = require('vs/nls'); import { Action } from 'vs/base/common/actions'; import product from 'vs/platform/product/common/product'; -import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { URI } from 'vs/base/common/uri'; import { IOpenerService } from 'vs/platform/opener/common/opener'; import { MenuRegistry, MenuId } from 'vs/platform/actions/common/actions'; -import { AbstractShowReleaseNotesAction } from 'vs/workbench/contrib/update/browser/update'; -export class OpenGettingStartedInBrowserAction extends Action { +export class ShowGettingStartedAction extends Action { + static ID = 'update.showGettingStarted'; + static LABEL = nls.localize('showReleaseNotes', "Show Getting Started"); constructor( + id = ShowGettingStartedAction.ID, + label = ShowGettingStartedAction.LABEL, @IOpenerService private openerService: IOpenerService ) { - super('update.openGettingStartedGuide', nls.localize('gettingStarted', "Get Started"), undefined, true); + super(id, label, undefined, true); } override run(): Promise { @@ -26,24 +28,10 @@ export class OpenGettingStartedInBrowserAction extends Action { } } -export class ShowCurrentReleaseNotesAction extends AbstractShowReleaseNotesAction { - - static ID = 'update.showGettingStarted'; - static LABEL = nls.localize('showReleaseNotes', "Show Getting Started"); - - constructor( - id = ShowCurrentReleaseNotesAction.ID, - label = ShowCurrentReleaseNotesAction.LABEL, - @IInstantiationService instantiationService: IInstantiationService - ) { - super(id, label, product.version, instantiationService); - } -} - MenuRegistry.appendMenuItem(MenuId.MenubarHelpMenu, { group: '1_welcome', command: { - id: ShowCurrentReleaseNotesAction.ID, + id: ShowGettingStartedAction.ID, title: nls.localize({ key: 'miGettingStarted', comment: ['&& denotes a mnemonic'] }, "Getting &&Started") }, order: 1 diff --git a/src/vs/workbench/workbench.desktop.main.ts b/src/vs/workbench/workbench.desktop.main.ts index 1ffd314842..73fd20418e 100644 --- a/src/vs/workbench/workbench.desktop.main.ts +++ b/src/vs/workbench/workbench.desktop.main.ts @@ -165,8 +165,8 @@ import 'vs/workbench/contrib/cli/node/cli.contribution'; //#endregion // {{SQL CARBON EDIT}} -// release notes -import 'sql/workbench/update/electron-browser/releaseNotes.contribution'; +// getting started +import 'sql/workbench/update/electron-browser/gettingStarted.contribution'; // query history import 'sql/workbench/contrib/queryHistory/electron-browser/queryHistory.contribution';