From 1fb3faeda1fc693675e1a7b3b00cacb89c7276e0 Mon Sep 17 00:00:00 2001 From: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Date: Mon, 9 Mar 2020 18:10:24 -0700 Subject: [PATCH] Notebooks: Fix Internal Links on Windows (#9513) * Improve workbench file path detection * Use fspath instead --- .../contrib/notebook/browser/cellViews/linkHandler.directive.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/workbench/contrib/notebook/browser/cellViews/linkHandler.directive.ts b/src/sql/workbench/contrib/notebook/browser/cellViews/linkHandler.directive.ts index a02a8218bd..4c19aad3ee 100644 --- a/src/sql/workbench/contrib/notebook/browser/cellViews/linkHandler.directive.ts +++ b/src/sql/workbench/contrib/notebook/browser/cellViews/linkHandler.directive.ts @@ -58,7 +58,7 @@ export class LinkHandlerDirective { // ignore } if (uri && this.openerService && this.isSupportedLink(uri)) { - if (uri.fragment && uri.fragment.length > 0 && uri.path === this.workbenchFilePath.path) { + if (uri.fragment && uri.fragment.length > 0 && uri.fsPath === this.workbenchFilePath.fsPath) { this.notebookService.navigateTo(this.notebookUri, uri.fragment); } else { this.openerService.open(uri).catch(onUnexpectedError);