From 206188f3ab8068e61e9412b4cea9d33fd2f4ad16 Mon Sep 17 00:00:00 2001 From: Cory Rivera Date: Mon, 14 Mar 2022 10:32:26 -0700 Subject: [PATCH] Add missing onNotebook:* activation event for VS Code notebook compatibility. (#18710) --- .../services/notebook/browser/notebookServiceImpl.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/sql/workbench/services/notebook/browser/notebookServiceImpl.ts b/src/sql/workbench/services/notebook/browser/notebookServiceImpl.ts index 34478ac5e5..272a742b13 100644 --- a/src/sql/workbench/services/notebook/browser/notebookServiceImpl.ts +++ b/src/sql/workbench/services/notebook/browser/notebookServiceImpl.ts @@ -382,9 +382,10 @@ export class NotebookService extends Disposable implements INotebookService { // Emit activation event if the provider is not one of the default options if (p.id !== SQL_NOTEBOOK_PROVIDER && p.id !== JUPYTER_PROVIDER_ID) { - this._extensionService.whenInstalledExtensionsRegistered().then(() => { - this._extensionService.activateByEvent(`onNotebook:${p.id}`).catch(err => onUnexpectedError(err)); - }).catch(err => onUnexpectedError(err)); + this._extensionService.whenInstalledExtensionsRegistered() + .then(() => this._extensionService.activateByEvent(`onNotebook:${p.id}`)) + .then(() => this._extensionService.activateByEvent(`onNotebook:*`)) + .catch(err => onUnexpectedError(err)); } }