ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-19 09:35:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adds toggle button to switch between estimated and actual execution plans (#19629)

Browse Source 
* Creates toggle button to switch between estimate and actual query plans

* Renames ID for the toggleActualExecutionPlanModeAction class

* Renames button back to explain

* Creating actual execution plans resembles SSMS

* Adds CTRL/CMD + L shortcut to display estimated execution plans

* Alphabetically organizes telemetry actions

* Adds telemetry when the setting for actual execution plan toggle is used

* Resolves build errors

* Fixes broken unit tests.

* Code review changes

* Removes unnecessary null-coalescing operator.

* Creates placeholder icons for actual execution plans enabled

* Code review changes

* Shortens label names

* Telemetry moved to toggle button

* Telemetry review changes

* Clarifies misleading label
This commit is contained in:
Lewis Sanchez
2022-06-09 16:07:12 -07:00
committed by GitHub
parent b1d8e43569
commit 20d2256709
12 changed files with 159 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/sql/base/browser/ui/taskbar/media/disabled-actual-execution-plan-inverse.svg Normal file
View File

@@ -0,0 +1 @@
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><defs><style>.cls-1{fill:#fff;}</style></defs><title>query_plan_inverse_16x16</title><path class="cls-1" d="M13.06,10.49H15v5H10.22v-5h1.89v-2H3.59v2H5.48v5H.75v-5h1.9v-3H7.38v-2H5.48v-5h4.74v5H8.33v2h4.74Zm-8.53,4v-3H1.69v3Zm1.9-13v3H9.27v-3Zm7.58,13v-3H11.17v3Z"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 365 B

1
src/sql/base/browser/ui/taskbar/media/disabled-actual-execution-plan.svg Normal file
View File

@@ -0,0 +1 @@
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><title>query_plan_16x16</title><path d="M13.16,10.59h1.9v5H10.32v-5h1.89v-2H3.68v2H5.58v5H.84v-5h1.9v-3H7.47v-2H5.58v-5h4.74v5H8.42v2h4.74Zm-8.53,4v-3H1.79v3Zm1.9-13v3H9.37v-3Zm7.58,13v-3H11.26v3Z"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 298 B

1
src/sql/base/browser/ui/taskbar/media/enabled-actual-execution-plan-inverse.svg Normal file
View File

@@ -0,0 +1 @@
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><defs><style>.cls-1{fill:#fff;}</style></defs><title>query_plan_inverse_16x16</title><path class="cls-1" d="M13.06,10.49H15v5H10.22v-5h1.89v-2H3.59v2H5.48v5H.75v-5h1.9v-3H7.38v-2H5.48v-5h4.74v5H8.33v2h4.74Zm-8.53,4v-3H1.69v3Zm1.9-13v3H9.27v-3Zm7.58,13v-3H11.17v3Z"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 365 B

1
src/sql/base/browser/ui/taskbar/media/enabled-actual-execution-plan.svg Normal file
View File

@@ -0,0 +1 @@
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><title>query_plan_16x16</title><path d="M13.16,10.59h1.9v5H10.32v-5h1.89v-2H3.68v2H5.58v5H.84v-5h1.9v-3H7.47v-2H5.58v-5h4.74v5H8.42v2h4.74Zm-8.53,4v-3H1.79v3Zm1.9-13v3H9.37v-3Zm7.58,13v-3H11.26v3Z"/></svg>
Side by Side

After

Width:  |  Height:  |  Size: 298 B

18
src/sql/base/browser/ui/taskbar/media/icons.css
View File

@@ -65,6 +65,14 @@
background-image: url('query-plan.svg');
}
.vs .codicon.disabledActualExecutionPlan {
background-image: url('disabled-actual-execution-plan.svg');
}
.vs .codicon.enabledActualExecutionPlan {
background-image: url('enabled-actual-execution-plan.svg');
}
.vs-dark .codicon.estimatedQueryPlan,
.hc-black .codicon.estimatedQueryPlan,
.vs-dark .codicon.actualQueryPlan,
@@ -72,6 +80,16 @@
background-image: url('query-plan-inverse.svg');
}
.vs-dark .codicon.codicon.disabledActualExecutionPlan,
.hc-black .codicon.codicon.disabledActualExecutionPlan {
background-image: url('disabled-actual-execution-plan-inverse.svg');
}
.vs-dark .codicon.codicon.enabledActualExecutionPlan,
.hc-black .codicon.codicon.enabledActualExecutionPlan {
background-image: url('enabled-actual-execution-plan-inverse.svg');
}
.vs .codicon.createInsight {
background-image: url('create_insight.svg');
}